linux-kernel - Re: [PATCH] mtd: spinand: fmsh: remove QE bit for FM25S01A flash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A71A9B2-6886-4250-A285-EDCA81242836@gmail.com>
Date: Mon, 03 Nov 2025 13:34:13 +0800
From: Tianling Shen <cnsztl@...il.com>
To: Mikhail Kshevetskiy <mikhail.kshevetskiy@...sys.eu>
CC: Miquel Raynal <miquel.raynal@...tlin.com>,
 Richard Weinberger <richard@....at>, Vignesh Raghavendra <vigneshr@...com>,
 linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: spinand: fmsh: remove QE bit for FM25S01A flash

Hi Mikhail,

On November 3, 2025 9:01:48 AM GMT+08:00, Mikhail Kshevetskiy <mikhail.kshevetskiy@...sys.eu> wrote:
>According to datasheet (http://eng.fmsh.com/nvm/FM25S01A_ds_eng.pdf)
>there is no QE (Quad Enable) bit for FM25S01A flash, so remove it.

Thank you so much for the fix!

>
>Fixes: 5f284dc15ca86 ("mtd: spinand: add support for FudanMicro FM25S01A")
>Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@...sys.eu>

Tested-by: Tianling Shen <cnsztl@...il.com>

Thanks,
Tianling.

>---
> drivers/mtd/nand/spi/fmsh.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/mtd/nand/spi/fmsh.c b/drivers/mtd/nand/spi/fmsh.c
>index 8b2097bfc771..c2b9a8c113cb 100644
>--- a/drivers/mtd/nand/spi/fmsh.c
>+++ b/drivers/mtd/nand/spi/fmsh.c
>@@ -58,7 +58,7 @@ static const struct spinand_info fmsh_spinand_table[] = {
> 		     SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
> 					      &write_cache_variants,
> 					      &update_cache_variants),
>-		     SPINAND_HAS_QE_BIT,
>+		     0,
> 		     SPINAND_ECCINFO(&fm25s01a_ooblayout, NULL)),
> };
> 
>-- 
>2.51.0
>