[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <2025110336-hummus-stank-e5ff@gregkh>
Date: Mon, 3 Nov 2025 14:27:37 +0900
From: Greg KH <gregkh@...uxfoundation.org>
To: Badhri Jagan Sridharan <badhri@...gle.com>
Cc: heikki.krogerus@...ux.intel.com, amitsd@...gle.com, kyletso@...gle.com,
rdbabiera@...gle.com, linux-kernel@...r.kernel.org,
linux-usb@...r.kernel.org
Subject: Re: [PATCH v2 0/1] TCPM logbuffer wraparound
On Mon, Nov 03, 2025 at 05:24:49AM +0000, Badhri Jagan Sridharan wrote:
> This is a follow up on a previous discussion:
> https://lore.kernel.org/lkml/20230410073134.488762-1-badhri@google.com/.
>
> With this change, TCPM log buffer will now wrap around when full and
> will not self-clear upon being read (dumped). A Kconfig option and a
> corresponding debugfs file node are introduced to allow opt-in back to
> the previous, non-wrapping, self-clearing behavior if required.
> This is an interim step while TCPM logging infrastructure is migrated
> to the standard event trace system.
Ick, no, let's just move to the standard trace format instead. That
should be much simpler and get rid of custom user/kernel apis and
Kconfig options. Overall you should end up removing a bunch of code
instead of adding new complexity like this.
thanks,
greg k-h
Powered by blists - more mailing lists