linux-kernel - Re: [PATCH] lib/crypto: arm, arm64: Drop filenames from file comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMj1kXHj9mcJsQHNUgJtn_X6iZsTRz11fBupjOzxBR-E2k_4WQ@mail.gmail.com>
Date: Mon, 3 Nov 2025 09:15:22 +0100
From: Ard Biesheuvel <ardb@...nel.org>
To: Eric Biggers <ebiggers@...nel.org>
Cc: linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org, 
	"Jason A . Donenfeld" <Jason@...c4.com>, Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [PATCH] lib/crypto: arm, arm64: Drop filenames from file comments

On Sun, 2 Nov 2025 at 02:48, Eric Biggers <ebiggers@...nel.org> wrote:
>
> Remove self-references to filenames from assembly files in
> lib/crypto/arm/ and lib/crypto/arm64/.  This follows the recommended
> practice and eliminates an outdated reference to sha2-ce-core.S.
>
> Signed-off-by: Eric Biggers <ebiggers@...nel.org>
> ---
>
> This patch is targeting libcrypto-next
>
>  lib/crypto/arm/sha1-armv7-neon.S  | 2 +-
>  lib/crypto/arm/sha1-ce-core.S     | 2 +-
>  lib/crypto/arm/sha256-ce.S        | 2 +-
>  lib/crypto/arm64/sha1-ce-core.S   | 2 +-
>  lib/crypto/arm64/sha256-ce.S      | 2 +-
>  lib/crypto/arm64/sha512-ce-core.S | 2 +-
>  6 files changed, 6 insertions(+), 6 deletions(-)
>

Reviewed-by: Ard Biesheuvel <ardb@...nel.org>

> diff --git a/lib/crypto/arm/sha1-armv7-neon.S b/lib/crypto/arm/sha1-armv7-neon.S
> index 6edba3ab62e8..a0323fa5c58a 100644
> --- a/lib/crypto/arm/sha1-armv7-neon.S
> +++ b/lib/crypto/arm/sha1-armv7-neon.S
> @@ -1,7 +1,7 @@
>  /* SPDX-License-Identifier: GPL-2.0-or-later */
> -/* sha1-armv7-neon.S - ARM/NEON accelerated SHA-1 transform function
> +/* ARM/NEON accelerated SHA-1 transform function
>   *
>   * Copyright © 2013-2014 Jussi Kivilinna <jussi.kivilinna@....fi>
>   */
>
>  #include <linux/linkage.h>
> diff --git a/lib/crypto/arm/sha1-ce-core.S b/lib/crypto/arm/sha1-ce-core.S
> index 2de40dd25e47..7d6b2631ca8d 100644
> --- a/lib/crypto/arm/sha1-ce-core.S
> +++ b/lib/crypto/arm/sha1-ce-core.S
> @@ -1,8 +1,8 @@
>  /* SPDX-License-Identifier: GPL-2.0-only */
>  /*
> - * sha1-ce-core.S - SHA-1 secure hash using ARMv8 Crypto Extensions
> + * SHA-1 secure hash using ARMv8 Crypto Extensions
>   *
>   * Copyright (C) 2015 Linaro Ltd.
>   * Author: Ard Biesheuvel <ard.biesheuvel@...aro.org>
>   */
>
> diff --git a/lib/crypto/arm/sha256-ce.S b/lib/crypto/arm/sha256-ce.S
> index 7481ac8e6c0d..144ee805f64a 100644
> --- a/lib/crypto/arm/sha256-ce.S
> +++ b/lib/crypto/arm/sha256-ce.S
> @@ -1,8 +1,8 @@
>  /* SPDX-License-Identifier: GPL-2.0-only */
>  /*
> - * sha256-ce.S - SHA-224/256 secure hash using ARMv8 Crypto Extensions
> + * SHA-224/256 secure hash using ARMv8 Crypto Extensions
>   *
>   * Copyright (C) 2015 Linaro Ltd.
>   * Author: Ard Biesheuvel <ard.biesheuvel@...aro.org>
>   */
>
> diff --git a/lib/crypto/arm64/sha1-ce-core.S b/lib/crypto/arm64/sha1-ce-core.S
> index 21efbbafd7d6..8fbd4767f0f0 100644
> --- a/lib/crypto/arm64/sha1-ce-core.S
> +++ b/lib/crypto/arm64/sha1-ce-core.S
> @@ -1,8 +1,8 @@
>  /* SPDX-License-Identifier: GPL-2.0-only */
>  /*
> - * sha1-ce-core.S - SHA-1 secure hash using ARMv8 Crypto Extensions
> + * SHA-1 secure hash using ARMv8 Crypto Extensions
>   *
>   * Copyright (C) 2014 Linaro Ltd <ard.biesheuvel@...aro.org>
>   */
>
>  #include <linux/linkage.h>
> diff --git a/lib/crypto/arm64/sha256-ce.S b/lib/crypto/arm64/sha256-ce.S
> index 410174ba5237..e4bfe42a61a9 100644
> --- a/lib/crypto/arm64/sha256-ce.S
> +++ b/lib/crypto/arm64/sha256-ce.S
> @@ -1,8 +1,8 @@
>  /* SPDX-License-Identifier: GPL-2.0-only */
>  /*
> - * sha2-ce-core.S - core SHA-224/SHA-256 transform using v8 Crypto Extensions
> + * Core SHA-224/SHA-256 transform using v8 Crypto Extensions
>   *
>   * Copyright (C) 2014 Linaro Ltd <ard.biesheuvel@...aro.org>
>   */
>
>  #include <linux/linkage.h>
> diff --git a/lib/crypto/arm64/sha512-ce-core.S b/lib/crypto/arm64/sha512-ce-core.S
> index 22f1ded89bc8..ffd51acfd1ee 100644
> --- a/lib/crypto/arm64/sha512-ce-core.S
> +++ b/lib/crypto/arm64/sha512-ce-core.S
> @@ -1,8 +1,8 @@
>  /* SPDX-License-Identifier: GPL-2.0 */
>  /*
> - * sha512-ce-core.S - core SHA-384/SHA-512 transform using v8 Crypto Extensions
> + * Core SHA-384/SHA-512 transform using v8 Crypto Extensions
>   *
>   * Copyright (C) 2018 Linaro Ltd <ard.biesheuvel@...aro.org>
>   *
>   * This program is free software; you can redistribute it and/or modify
>   * it under the terms of the GNU General Public License version 2 as
>
> base-commit: 5a2a5e62a5216ba05d4481cf90d915f4de0bfde9
> --
> 2.51.2
>