linux-kernel - Re: [PATCH] crypto: x86/aes-gcm-vaes-avx2 - initialize full %rax return register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMj1kXEJAqt6_QKg12Ejf6RRpvOfh5bhPRg-7wwoB-A8uDKj6Q@mail.gmail.com>
Date: Mon, 3 Nov 2025 09:16:43 +0100
From: Ard Biesheuvel <ardb@...nel.org>
To: Eric Biggers <ebiggers@...nel.org>
Cc: linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org, 
	"Jason A . Donenfeld" <Jason@...c4.com>, Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [PATCH] crypto: x86/aes-gcm-vaes-avx2 - initialize full %rax
 return register

On Sun, 2 Nov 2025 at 02:53, Eric Biggers <ebiggers@...nel.org> wrote:
>
> Update aes_gcm_dec_final_vaes_avx2() to be consistent with
> aes_gcm_dec_final_aesni() and aes_gcm_dec_final_vaes_avx512() by
> initializing the full %rax return register instead of just %al.
> Technically this is unnecessary, since these functions return bool.  But
> I think it's worth being extra careful with the result of the tag
> comparison and also keeping the different implementations consistent.
>
> Signed-off-by: Eric Biggers <ebiggers@...nel.org>
> ---
>
> This patch is targeting libcrypto-next
>
>  arch/x86/crypto/aes-gcm-vaes-avx2.S | 1 +
>  1 file changed, 1 insertion(+)
>

Reviewed-by: Ard Biesheuvel <ardb@...nel.org>