linux-kernel - Re: [PATCH 04/11] soc: samsung: exynos-chipid: refer to match->data as data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251103-spoonbill-of-incredible-resistance-d5befc@kuoka>
Date: Mon, 3 Nov 2025 11:05:38 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Tudor Ambarus <tudor.ambarus@...aro.org>
Cc: Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Alim Akhtar <alim.akhtar@...sung.com>, Peter Griffin <peter.griffin@...aro.org>, 
	André Draszik <andre.draszik@...aro.org>, semen.protsenko@...aro.org, willmcvicker@...gle.com, 
	kernel-team@...roid.com, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/11] soc: samsung: exynos-chipid: refer to match->data
 as data

On Fri, Oct 31, 2025 at 12:56:03PM +0000, Tudor Ambarus wrote:
> Be consistent across the driver and refer to match->data as data.
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@...aro.org>
> ---
>  drivers/soc/samsung/exynos-chipid.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c
> index f5107b8b339e8884d6a67a80650a95441510c66c..ab6bdf24a754a0faf974190c1fa1f99735cbef8e 100644
> --- a/drivers/soc/samsung/exynos-chipid.c
> +++ b/drivers/soc/samsung/exynos-chipid.c
> @@ -106,7 +106,7 @@ static int exynos_chipid_get_chipid_info(struct regmap *regmap,
>  
>  static int exynos_chipid_probe(struct platform_device *pdev)
>  {
> -	const struct exynos_chipid_variant *drv_data;
> +	const struct exynos_chipid_variant *data;

I would prefer name drv_data, to mark clearly this is driver data.
Sometimes driver state container is called "data".

Best regards,
Krzysztof