linux-kernel - Re: [PATCH RESEND 1/3] dt-bindings: PCI: amlogic: Fix the register name of the DBI region

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <rguwscxck7vel3hjdd2hlkypzdbwdvafdryxtz5benweduh4eg@sny4rr2nx5aq>
Date: Mon, 3 Nov 2025 15:42:58 +0530
From: Manivannan Sadhasivam <mani@...nel.org>
To: Neil Armstrong <neil.armstrong@...aro.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@....qualcomm.com>, 
	Bjorn Helgaas <bhelgaas@...gle.com>, Lorenzo Pieralisi <lpieralisi@...nel.org>, 
	Krzysztof Wilczyński <kwilczynski@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Hanjie Lin <hanjie.lin@...ogic.com>, Yue Wang <yue.wang@...ogic.com>, 
	Kevin Hilman <khilman@...libre.com>, Jerome Brunet <jbrunet@...libre.com>, 
	Martin Blumenstingl <martin.blumenstingl@...glemail.com>, Andrew Murray <amurray@...goodpenguin.co.uk>, 
	Jingoo Han <jingoohan1@...il.com>, Krishna Chaitanya Chundru <krishna.chundru@....qualcomm.com>, 
	linux-pci@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-amlogic@...ts.infradead.org
Subject: Re: [PATCH RESEND 1/3] dt-bindings: PCI: amlogic: Fix the register
 name of the DBI region

On Mon, Nov 03, 2025 at 10:47:36AM +0100, Neil Armstrong wrote:
> Hi Mani,
> 
> On 11/1/25 05:29, Manivannan Sadhasivam wrote:
> > Binding incorrectly specifies the 'DBI' region as 'ELBI'. DBI is a must
> > have region for DWC controllers as it has the Root Port and controller
> > specific registers, while ELBI has optional registers.
> > 
> > Hence, fix the binding. Though this is an ABI break, this change is needed
> > to accurately describe the PCI memory map.
> 
> Not fan of this ABI break, the current bindings should be marked as deprecated instead.
> 

Fair enough. Will make it as deprecated.

- Mani

> > 
> > Fixes: 7cd210391101 ("dt-bindings: PCI: meson: add DT bindings for Amlogic Meson PCIe controller")
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@....qualcomm.com>
> > ---
> >   Documentation/devicetree/bindings/pci/amlogic,axg-pcie.yaml | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/pci/amlogic,axg-pcie.yaml b/Documentation/devicetree/bindings/pci/amlogic,axg-pcie.yaml
> > index 79a21ba0f9fd62804ba95fe8a6cc3252cf652197..c8258ef4032834d87cf3160ffd1d93812801b62a 100644
> > --- a/Documentation/devicetree/bindings/pci/amlogic,axg-pcie.yaml
> > +++ b/Documentation/devicetree/bindings/pci/amlogic,axg-pcie.yaml
> > @@ -36,13 +36,13 @@ properties:
> >     reg:
> >       items:
> > -      - description: External local bus interface registers
> > +      - description: Data Bus Interface registers
> >         - description: Meson designed configuration registers
> >         - description: PCIe configuration space
> >     reg-names:
> >       items:
> > -      - const: elbi
> > +      - const: dbi
> >         - const: cfg
> >         - const: config
> > @@ -113,7 +113,7 @@ examples:
> >       pcie: pcie@...00000 {
> >           compatible = "amlogic,axg-pcie", "snps,dw-pcie";
> >           reg = <0xf9800000 0x400000>, <0xff646000 0x2000>, <0xf9f00000 0x100000>;
> > -        reg-names = "elbi", "cfg", "config";
> > +        reg-names = "dbi", "cfg", "config";
> >           interrupts = <GIC_SPI 177 IRQ_TYPE_EDGE_RISING>;
> >           clocks = <&pclk>, <&clk_port>, <&clk_phy>;
> >           clock-names = "pclk", "port", "general";
> > 
> 

-- 
மணிவண்ணன் சதாசிவம்