linux-kernel - Re: [PATCH v4 2/2] arm64: dts: qcom: msm8953-lenovo-kuntao: Add initial device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <93c4a167-805b-47f0-8e4b-76b1aeabb87e@kernel.org>
Date: Mon, 3 Nov 2025 12:25:24 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
 Raihan Ahamed <raihan1999ahamed@...il.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Kees Cook <kees@...nel.org>,
 Tony Luck <tony.luck@...el.com>, "Guilherme G . Piccoli"
 <gpiccoli@...lia.com>, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org
Subject: Re: [PATCH v4 2/2] arm64: dts: qcom: msm8953-lenovo-kuntao: Add
 initial device tree

On 03/11/2025 12:23, Konrad Dybcio wrote:
>> +
>> +		one-key-low-power {
>> +			label = "onekeylowpower";
>> +			gpios = <&tlmm 86 GPIO_ACTIVE_LOW>;
>> +			linux,code = <ABS_HAT1Y>;
>> +			debounce-interval = <15>;
>> +		};
>> +
>> +		homepage {
>> +			label = "homepage";
>> +			gpios = <&tlmm 132 GPIO_ACTIVE_LOW>;
>> +			linux,code = <KEY_HOMEPAGE>;
>> +			debounce-interval = <15>;
>> +			gpio-key,wakeup;
>> +		};
> 
> Please sort these nodes without an address by their name> +	};
>> +

These will also fail tests :/

Best regards,
Krzysztof