linux-kernel - [PATCH] usb: musb: ux500: Fix PHY resource leak in error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251103020204.796-1-vulab@iscas.ac.cn>
Date: Mon,  3 Nov 2025 10:02:04 +0800
From: Haotian Zhang <vulab@...as.ac.cn>
To: Bin Liu <b-liu@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Haotian Zhang <vulab@...as.ac.cn>
Subject: [PATCH] usb: musb: ux500: Fix PHY resource leak in error path

The ux500_musb_init() function calls usb_get_phy() to obtain a PHY
resource, but fails to release it with usb_put_phy() when
usb_register_notifier() fails. This leads to a resource leak as the
PHY reference count is not properly decremented.

Add usb_put_phy() call in the error path before returning to ensure
the PHY resource is properly released when notifier registration fails.

Fixes: 0135522c4898 ("usb: musb: ux500: add otg notifier support")
Signed-off-by: Haotian Zhang <vulab@...as.ac.cn>
---
 drivers/usb/musb/ux500.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/musb/ux500.c b/drivers/usb/musb/ux500.c
index 8c2a43d992f5..14c5e986937e 100644
--- a/drivers/usb/musb/ux500.c
+++ b/drivers/usb/musb/ux500.c
@@ -155,6 +155,7 @@ static int ux500_musb_init(struct musb *musb)
 	status = usb_register_notifier(musb->xceiv, &musb->nb);
 	if (status < 0) {
 		dev_dbg(musb->controller, "notification register failed\n");
+		usb_put_phy(musb->xceiv);
 		return status;
 	}
 
-- 
2.50.1.windows.1