linux-kernel - Re: [PATCH 01/13] platform/raspberrypi: vchiq-mmal: Avoid use of bool in structures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <176217615029.8690.11618877016123000092@freya>
Date: Mon, 03 Nov 2025 18:52:30 +0530
From: Jai Luthra <jai.luthra@...asonboard.com>
To: Christian König <christian.koenig@....com>, Krzysztof Kozlowski <krzk@...nel.org>, Florian Fainelli <florian.fainelli@...adcom.com>, Raspberry Pi Kernel Maintenance <kernel-list@...pberrypi.com>, bcm-kernel-feedback-list@...adcom.com
Cc: Dave Stevenson <dave.stevenson@...pberrypi.com>, Phil Elwell <phil@...pberrypi.com>, Stefan Wahren <wahrenst@....net>, Laurent Pinchart <laurent.pinchart@...asonboard.com>, Kieran Bingham <kieran.bingham@...asonboard.com>, Sumit Semwal <sumit.semwal@...aro.org>, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, Dave Stevenson <dave.stevenson@...pberrypi.org>
Subject: Re: [PATCH 01/13] platform/raspberrypi: vchiq-mmal: Avoid use of bool in structures

Hi Christian, Krzyztof,

Quoting Christian König (2025-11-03 16:39:15)
> On 10/31/25 18:27, Jai Luthra wrote:
> > From: Dave Stevenson <dave.stevenson@...pberrypi.org>
> > 
> > Fixes up a checkpatch error "Avoid using bool structure members
> > because of possible alignment issues".
> 
> Mhm, at least of hand that doesn't looks correct to me.
> 
> What exactly is the checkpatch.pl error or warning message you get?

My bad, commit 640e77466e69 ("staging: mmal-vchiq: Avoid use of bool in
structures") that had switched vchiq_mmal_component.enabled from a bool to
1-bit bitfield has already been reverted in mainline.. this stray change
seems to have persisted in RPi's downstream kernel.

I'll drop this and other irrelevant changes in the next revision of this
series.

> 
> Regards,
> Christian.
> 
> > 
> > Signed-off-by: Dave Stevenson <dave.stevenson@...pberrypi.org>
> > Signed-off-by: Jai Luthra <jai.luthra@...asonboard.com>
> > ---
> >  drivers/platform/raspberrypi/vchiq-mmal/mmal-vchiq.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/platform/raspberrypi/vchiq-mmal/mmal-vchiq.c b/drivers/platform/raspberrypi/vchiq-mmal/mmal-vchiq.c
> > index cd073ed3ea2dd9c45b137f1a32e236e520b7b320..82c2c261fd9cf0669cbd2ca7c814e0703317885a 100644
> > --- a/drivers/platform/raspberrypi/vchiq-mmal/mmal-vchiq.c
> > +++ b/drivers/platform/raspberrypi/vchiq-mmal/mmal-vchiq.c
> > @@ -1776,7 +1776,7 @@ int vchiq_mmal_component_enable(struct vchiq_mmal_instance *instance,
> >  
> >       ret = enable_component(instance, component);
> >       if (ret == 0)
> > -             component->enabled = true;
> > +             component->enabled = 1;
> >  
> >       mutex_unlock(&instance->vchiq_mutex);
> >  
> > 
> 

Thanks,
Jai