linux-kernel - Re: [PATCH v2 1/2] rust: add BitInt integer wrapping type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DDZ3QLIXUP5Y.1W6RGF1RWGNSL@nvidia.com>
Date: Mon, 03 Nov 2025 22:42:35 +0900
From: "Alexandre Courbot" <acourbot@...dia.com>
To: "Alice Ryhl" <aliceryhl@...gle.com>, "Alexandre Courbot"
 <acourbot@...dia.com>
Cc: "Danilo Krummrich" <dakr@...nel.org>, "Miguel Ojeda" <ojeda@...nel.org>,
 "Joel Fernandes" <joelagnelf@...dia.com>, "Yury Norov"
 <yury.norov@...il.com>, "Jesung Yang" <y.j3ms.n@...il.com>, "Boqun Feng"
 <boqun.feng@...il.com>, "Gary Guo" <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>, "Benno Lossin"
 <lossin@...nel.org>, "Andreas Hindborg" <a.hindborg@...nel.org>, "Trevor
 Gross" <tmgross@...ch.edu>, <linux-kernel@...r.kernel.org>,
 <rust-for-linux@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] rust: add BitInt integer wrapping type

On Mon Nov 3, 2025 at 7:49 PM JST, Alice Ryhl wrote:
> On Mon, Nov 03, 2025 at 10:17:48AM +0000, Alice Ryhl wrote:
>> On Sun, Nov 02, 2025 at 11:24:42PM +0900, Alexandre Courbot wrote:
>> > Add the `BitInt` type, which is an integer on which the number of bits
>> > allowed to be used is restricted, capping its maximal value below that
>> > of primitive type is wraps.
>> > 
>> > This is useful to e.g. enforce guarantees when working with bit fields.
>> > 
>> > Alongside this type, provide many `From` and `TryFrom` implementations
>> > are to reduce friction when using with regular integer types. Proxy
>> > implementations of common integer traits are also provided.
>> > 
>> > Signed-off-by: Alexandre Courbot <acourbot@...dia.com>
>> 
>> Reviewed-by: Alice Ryhl <aliceryhl@...gle.com>
>
> Actually, I saw Yury's comments on v1 and I have some additional comments
> as well. See my reply there.

Gotcha - ignoring your Reviewed-by tag for now.