linux-kernel - Re: [PATCH] nvmet-auth: update sc_c in target host hash calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <82a1b667-428f-4bc5-8326-63f9e729c460@suse.de>
Date: Mon, 3 Nov 2025 14:57:47 +0100
From: Hannes Reinecke <hare@...e.de>
To: Alistair Francis <alistair23@...il.com>
Cc: kbusch@...nel.org, axboe@...nel.dk, hch@....de, sagi@...mberg.me,
 kch@...dia.com, linux-nvme@...ts.infradead.org,
 linux-kernel@...r.kernel.org, Alistair Francis <alistair.francis@....com>
Subject: Re: [PATCH] nvmet-auth: update sc_c in target host hash calculation

On 11/3/25 03:28, Alistair Francis wrote:
> On Wed, Oct 29, 2025 at 9:33 PM Hannes Reinecke <hare@...e.de> wrote:
>>
>> On 10/29/25 12:20, Alistair Francis wrote:
>>> On Wed, Oct 29, 2025 at 6:10 PM Hannes Reinecke <hare@...e.de> wrote:
>>>>
>>>> On 10/29/25 05:53, alistair23@...il.com wrote:
>>>>> From: Alistair Francis <alistair.francis@....com>
>>>>>
>>>>> Commit 7e091add9c43 "nvme-auth: update sc_c in host response" added
>>>>> the sc_c variable to the dhchap queue context structure which is
>>>>> appropriately set during negotiate and then used in the host response.
>>>>>
>>>>> This breaks secure concat connections with a Linux target as the target
>>>>> code wasn't updated at the same time. This patch fixes this by adding a
>>>>> new sc_c variable to the host hash calculations.
>>>>>
>>>>> Signed-off-by: Alistair Francis <alistair.francis@....com>
>>>>> ---
>>>>>     drivers/nvme/host/auth.c               | 1 +
>>>>>     drivers/nvme/target/auth.c             | 3 ++-
>>>>>     drivers/nvme/target/fabrics-cmd-auth.c | 1 +
>>>>>     drivers/nvme/target/nvmet.h            | 1 +
>>>>>     4 files changed, 5 insertions(+), 1 deletion(-)
>>>>>
>>>> I've already send a similar patch for this, which actually should
>>>> already have been merged.
>>>> Can you check if that works for you?
>>>
>>> I checked master when I sent this and there was nothing applied. Is it
>>> in a different tree?
>>>
>>
>> https://lore.kernel.org/linux-nvme/aPl4-6WQ940kUso7@kbusch-mbp/T/#t
> 
> Thanks.
> 
> Your patch is now in master, but doesn't fix the issue for me. I still
> get failures with a secure concat connection.
> 
> My patch (rebased on top of yours) fixes the issue for me
> 
Ah. So please add a proper 'Fixes' tag.
(and fixup the kbuild failure while at it ...)

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@...e.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich