linux-kernel - Re: [PATCH v2] efistub/x86: Add fallback for SMBIOS record lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <pt44dx2hnzvqrqsboa53p67qw4dhkslo3xme4uu5r333ygei2m@czvvf5btllhq>
Date: Mon, 3 Nov 2025 15:40:58 +0100
From: Francesco Pompo' <francescopompo2@...il.com>
To: Ard Biesheuvel <ardb@...nel.org>
Cc: linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] efistub/x86: Add fallback for SMBIOS record lookup

On Mon, Nov 03, 2025 at 02:47:22PM +0100, Ard Biesheuvel wrote:
> On Mon, 3 Nov 2025 at 13:33, Francesco Pompo <francescopompo2@...il.com> wrote:
> >
> > Some Apple EFI firmwares do not provide the SMBIOS Protocol,
> > causing efi_get_smbios_record() to fail. This prevents retrieval of
> > system information such as product name, which is needed by
> > apple_set_os() to enable the integrated GPU on dual-graphics Intel
> > MacBooks.
> >
> > Add a fallback that directly parses the SMBIOS entry point table when
> > the protocol is unavailable.
> >
> > Signed-off-by: Francesco Pompo <francescopompo2@...il.com>
> > ---
> >  drivers/firmware/efi/libstub/x86-stub.c | 107 +++++++++++++++++++++++-
> >  1 file changed, 106 insertions(+), 1 deletion(-)
> >
> 
> OK, I've pushed this to the efi/next branch now. I did apply some
> cosmetic tweaks, though, so please double check that I did not break
> anything.

Seems fine to me. I compiled it and it's working correctly on my
hardware.

Thank you! :)