linux-kernel - Re: [PATCH] RDMA/rtrs: server: Fix error handling in get_or_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <073e1aed-11d4-4410-b40c-1d4684f3c192@web.de>
Date: Tue, 4 Nov 2025 15:55:37 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: make24@...as.ac.cn, linux-rdma@...r.kernel.org
Cc: stable@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Danil Kipnis <danil.kipnis@...ud.ionos.com>,
 Haris Iqbal <haris.iqbal@...os.com>, Jack Wang <jinpu.wang@...os.com>,
 Jason Gunthorpe <jgg@...pe.ca>, Leon Romanovsky <leon@...nel.org>
Subject: Re: [PATCH] RDMA/rtrs: server: Fix error handling in
 get_or_create_srv

> get_or_create_srv() fails to call put_device() after
> device_initialize() when memory allocation fails. …

Why do you propose then to replace a kfree(srv) call by put_device(&srv->dev)?


Would an other word wrapping be a bit nicer for such a change description?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.18-rc4#n658

Regards,
Markus