| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CABtds-3V0qP2S-Zcco8D9SsEioNbKyXCmddAkEc9eS2+TCOucQ@mail.gmail.com>
Date: Tue, 4 Nov 2025 12:02:38 -0500
from: Sean Rhodes <sean@...rlabs.systems>
To: linux-kernel@...r.kernel.org
Subject: [PATCH] drivers/memstick/rtsx_usb_ms: throttle idle card polling
>From e7dca663b4e5aa347db010e34c7e53795f489486 Mon Sep 17 00:00:00 2001
From: Sean Rhodes <sean@...rlabs.systems>
Date: Tue, 4 Nov 2025 15:43:42 +0000
Subject: [PATCH 1/5] drivers/memstick/rtsx_usb_ms: throttle idle card polling
Track the poll interval in the memstick host and queue the work on
system_wq so we can switch between a 50 ms cadence when requests or
events are pending and a 1 s cadence while idle. Reset the interval
after power-on so newly inserted cards are still detected promptly.
Cc: Maxim Levitsky <maximlevitsky@...il.com>
Cc: Alex Dubov <oakad@...oo.com>
Cc: Ulf Hansson <ulf.hansson@...aro.org>
Cc: Ricky Wu <ricky_wu@...ltek.com>
Cc: Luo Qiu <luoqiu@...insec.com.cn>
Cc: Jiayi Li <lijiayi@...inos.cn>
Cc: linux-mmc@...r.kernel.org
Cc: linux-kernel@...r.kernel.org
Signed-off-by: Sean Rhodes <sean@...rlabs.systems>
---
drivers/memstick/host/rtsx_usb_ms.c | 25 +++++++++++++++++++++----
1 file changed, 21 insertions(+), 4 deletions(-)
diff --git a/drivers/memstick/host/rtsx_usb_ms.c
b/drivers/memstick/host/rtsx_usb_ms.c
index beadc389f15f..73677638a3f6 100644
--- a/drivers/memstick/host/rtsx_usb_ms.c
+++ b/drivers/memstick/host/rtsx_usb_ms.c
@@ -12,6 +12,7 @@
#include <linux/delay.h>
#include <linux/platform_device.h>
#include <linux/workqueue.h>
+#include <linux/jiffies.h>
#include <linux/memstick.h>
#include <linux/kthread.h>
#include <linux/rtsx_usb.h>
@@ -21,6 +22,9 @@
#include <linux/completion.h>
#include <linux/unaligned.h>
+#define RTSX_USB_MS_POLL_INTERVAL msecs_to_jiffies(50)
+#define RTSX_USB_MS_IDLE_POLL_INTERVAL msecs_to_jiffies(1000)
+
struct rtsx_usb_ms {
struct platform_device *pdev;
struct rtsx_ucr *ucr;
@@ -30,6 +34,7 @@ struct rtsx_usb_ms {
struct mutex host_mutex;
struct work_struct handle_req;
struct delayed_work poll_card;
+ unsigned long poll_interval;
u8 ssc_depth;
unsigned int clock;
@@ -635,8 +640,11 @@ static int rtsx_usb_ms_set_param(struct memstick_host *msh,
if (param == MEMSTICK_POWER && value == MEMSTICK_POWER_ON) {
usleep_range(10000, 12000);
- if (!host->eject)
- schedule_delayed_work(&host->poll_card, 100);
+ if (!host->eject) {
+ host->poll_interval = RTSX_USB_MS_POLL_INTERVAL;
+ queue_delayed_work(system_wq, &host->poll_card,
+ host->poll_interval);
+ }
}
dev_dbg(ms_dev(host), "%s: return = %d\n", __func__, err);
@@ -723,6 +731,7 @@ static void rtsx_usb_ms_poll_card(struct work_struct *work)
struct rtsx_ucr *ucr = host->ucr;
int err;
u8 val;
+ bool event_pending = false;
if (host->eject || host->power_mode != MEMSTICK_POWER_ON)
return;
@@ -747,13 +756,20 @@ static void rtsx_usb_ms_poll_card(struct
work_struct *work)
if (val & MS_INT) {
dev_dbg(ms_dev(host), "MS slot change detected\n");
memstick_detect_change(host->msh);
+ event_pending = true;
}
poll_again:
pm_runtime_put_sync(ms_dev(host));
- if (!host->eject && host->power_mode == MEMSTICK_POWER_ON)
- schedule_delayed_work(&host->poll_card, 100);
+ if (!host->eject && host->power_mode == MEMSTICK_POWER_ON) {
+ bool request_active = READ_ONCE(host->req) != NULL;
+ unsigned long delay = (event_pending || request_active) ?
+ RTSX_USB_MS_POLL_INTERVAL : RTSX_USB_MS_IDLE_POLL_INTERVAL;
+
+ host->poll_interval = delay;
+ queue_delayed_work(system_wq, &host->poll_card, delay);
+ }
}
static int rtsx_usb_ms_drv_probe(struct platform_device *pdev)
@@ -784,6 +800,7 @@ static int rtsx_usb_ms_drv_probe(struct
platform_device *pdev)
mutex_init(&host->host_mutex);
INIT_WORK(&host->handle_req, rtsx_usb_ms_handle_req);
+ host->poll_interval = RTSX_USB_MS_POLL_INTERVAL;
INIT_DELAYED_WORK(&host->poll_card, rtsx_usb_ms_poll_card);
msh->request = rtsx_usb_ms_request;
--
2.51.0
Powered by blists - more mailing lists