linux-kernel - Re: [PATCH v6 05/14] remoteproc: pas: Replace metadata context with PAS context structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1d13f465-aa9f-47ca-9721-f48a76ce0e03@oss.qualcomm.com>
Date: Tue, 4 Nov 2025 18:34:19 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Mukesh Ojha <mukesh.ojha@....qualcomm.com>,
        Bjorn Andersson <andersson@...nel.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
 <conor+dt@...nel.org>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, linux-remoteproc@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 05/14] remoteproc: pas: Replace metadata context with
 PAS context structure

On 11/4/25 6:33 PM, Konrad Dybcio wrote:
> On 11/4/25 8:35 AM, Mukesh Ojha wrote:
>> As a superset of the existing metadata context, the PAS context
>> structure enables both remoteproc and non-remoteproc subsystems to
>> better support scenarios where the SoC runs with or without the Gunyah
>> hypervisor. To reflect this, relevant SCM and metadata functions are
>> updated to incorporate PAS context awareness.
>>
>> Signed-off-by: Mukesh Ojha <mukesh.ojha@....qualcomm.com>
>> ---
>>  drivers/firmware/qcom/qcom_scm.c       | 25 +++++++++++++---------
>>  drivers/remoteproc/qcom_q6v5_pas.c     | 38 ++++++++++++++++++++++++----------
>>  drivers/soc/qcom/mdt_loader.c          |  4 ++--
>>  include/linux/firmware/qcom/qcom_scm.h |  4 ++--
>>  include/linux/soc/qcom/mdt_loader.h    |  6 +++---
>>  5 files changed, 49 insertions(+), 28 deletions(-)
>>
>> diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c
>> index 5a525dbd0a2e..9cdd152da592 100644
>> --- a/drivers/firmware/qcom/qcom_scm.c
>> +++ b/drivers/firmware/qcom/qcom_scm.c
>> @@ -603,7 +603,7 @@ EXPORT_SYMBOL_GPL(devm_qcom_scm_pas_context_init);
>>   *		and optional blob of data used for authenticating the metadata
>>   *		and the rest of the firmware
>>   * @size:	size of the metadata
>> - * @ctx:	optional metadata context
>> + * @ctx:	optional pas context
>>   *
>>   * Return: 0 on success.
>>   *
>> @@ -612,8 +612,9 @@ EXPORT_SYMBOL_GPL(devm_qcom_scm_pas_context_init);
>>   * qcom_scm_pas_metadata_release() by the caller.
>>   */
>>  int qcom_scm_pas_init_image(u32 pas_id, const void *metadata, size_t size,
>> -			    struct qcom_scm_pas_metadata *ctx)
>> +			    struct qcom_scm_pas_context *ctx)
>>  {
>> +	struct qcom_scm_pas_metadata *mdt_ctx;
> 
> This is never initialized

Pardon, I'm blind

Konrad