linux-kernel - Re: [PATCH v3 27/28] drm/intel/pciids: Add match with VFIO override

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3y2rsj2r27htdisspmulaoufy74w3rs7eramz4fezwcs6j5xuh@jzjrjasasryz>
Date: Tue, 4 Nov 2025 11:41:53 -0600
From: Lucas De Marchi <lucas.demarchi@...el.com>
To: Michał Winiarski <michal.winiarski@...el.com>
CC: Alex Williamson <alex@...zbot.org>, Thomas Hellström
	<thomas.hellstrom@...ux.intel.com>, Rodrigo Vivi <rodrigo.vivi@...el.com>,
	Jason Gunthorpe <jgg@...pe.ca>, Yishai Hadas <yishaih@...dia.com>, Kevin Tian
	<kevin.tian@...el.com>, Shameer Kolothum <skolothumtho@...dia.com>,
	<intel-xe@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
	<kvm@...r.kernel.org>, Matthew Brost <matthew.brost@...el.com>, "Michal
 Wajdeczko" <michal.wajdeczko@...el.com>, <dri-devel@...ts.freedesktop.org>,
	Jani Nikula <jani.nikula@...ux.intel.com>, Joonas Lahtinen
	<joonas.lahtinen@...ux.intel.com>, Tvrtko Ursulin <tursulin@...ulin.net>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, "Lukasz
 Laguna" <lukasz.laguna@...el.com>, Christoph Hellwig <hch@...radead.org>
Subject: Re: [PATCH v3 27/28] drm/intel/pciids: Add match with VFIO override

On Tue, Nov 04, 2025 at 01:59:45PM +0100, Michał Winiarski wrote:
>On Mon, Nov 03, 2025 at 03:30:49PM -0600, Lucas De Marchi wrote:
>> On Thu, Oct 30, 2025 at 09:31:34PM +0100, Michał Winiarski wrote:
>> > In order to allow VFIO users to choose the right driver override, VFIO
>> > driver variant used for VF migration needs to use Intel Graphics PCI
>> > IDs.
>> > Add INTEL_VGA_VFIO_DEVICE match that sets VFIO override_only.
>> >
>> > Signed-off-by: Michał Winiarski <michal.winiarski@...el.com>
>> > ---
>> > include/drm/intel/pciids.h | 7 +++++++
>> > 1 file changed, 7 insertions(+)
>> >
>> > diff --git a/include/drm/intel/pciids.h b/include/drm/intel/pciids.h
>> > index b258e79b437ac..d14ce43139a28 100644
>> > --- a/include/drm/intel/pciids.h
>> > +++ b/include/drm/intel/pciids.h
>> > @@ -43,6 +43,13 @@
>> > 	.class = PCI_BASE_CLASS_DISPLAY << 16, .class_mask = 0xff << 16, \
>> > 	.driver_data = (kernel_ulong_t)(_info), \
>> > }
>> > +
>> > +#define INTEL_VGA_VFIO_DEVICE(_id, _info) { \
>> > +	PCI_DEVICE(PCI_VENDOR_ID_INTEL, (_id)), \
>> > +	.class = PCI_BASE_CLASS_DISPLAY << 16, .class_mask = 0xff << 16, \
>> > +	.driver_data = (kernel_ulong_t)(_info), \
>> > +	.override_only = PCI_ID_F_VFIO_DRIVER_OVERRIDE, \
>>
>> why do we need this and can't use PCI_DRIVER_OVERRIDE_DEVICE_VFIO()
>> directly? Note that there are GPUs that wouldn't match the display class
>> above.
>>
>> 	edb660ad79ff ("drm/intel/pciids: Add match on vendor/id only")
>> 	5e0de2dfbc1b ("drm/xe/cri: Add CRI platform definition")
>>
>> Lucas De Marchi
>>
>
>I'll define it on xe-vfio-pci side and use

but no matter where it's defined, why do you need it to match on the
class? The vid/devid should be sufficient.

Lucas De Marchi