linux-kernel - Re: [PATCH 1/2] x86/mm: support memory-failure on 32-bits with SPARSEMEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251104022014.7716-1-xieyuanbin1@huawei.com>
Date: Tue, 4 Nov 2025 10:20:14 +0800
From: Xie Yuanbin <xieyuanbin1@...wei.com>
To: <bp@...en8.de>, <david@...hat.com>
CC: <Liam.Howlett@...cle.com>, <akpm@...ux-foundation.org>,
	<dave.hansen@...ux.intel.com>, <hpa@...or.com>, <liaohua4@...wei.com>,
	<lilinjie8@...wei.com>, <linmiaohe@...wei.com>, <linux-edac@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-mm@...ck.org>,
	<lorenzo.stoakes@...cle.com>, <luto@...nel.org>, <mhocko@...e.com>,
	<mingo@...hat.com>, <nao.horiguchi@...il.com>, <peterz@...radead.org>,
	<rppt@...nel.org>, <surenb@...gle.com>, <tglx@...utronix.de>,
	<tony.luck@...el.com>, <vbabka@...e.cz>, <will@...nel.org>, <x86@...nel.org>,
	<xieyuanbin1@...wei.com>
Subject: Re: [PATCH 1/2] x86/mm: support memory-failure on 32-bits with SPARSEMEM

On Mon, 3 Nov 2025 13:39:20 +0100, Borislav Petkov wrote:
>On Mon, Nov 03, 2025 at 01:15:58PM +0100, David Hildenbrand wrote:
>> I rather wonder whether the memory-tracing code should live in a
>> memory-failure.h instead.
>
> Yah, move it pls. It doesn't belong there.

Okay, I will try it in V2 patches.

I'm not very familiar with the implementation of trace.
A trace/events/memory-failure.h file should be added, and:
```c
#define CREATE_TRACE_POINTS
#include <trace/events/memory-failure.h>
```
should be added in memory-failure.c, right?

If I have made any mistakes, please point them out. Thanks!

Xie Yuanbin