linux-kernel - Re: [PATCH 0/4] platform/x86: wmi: Prepare for future changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e40a0d9c-7f38-44ab-a954-b09c9687ea88@kernel.org>
Date: Tue, 4 Nov 2025 14:52:30 -0600
From: Mario Limonciello <superm1@...nel.org>
To: Armin Wolf <W_Armin@....de>, viro@...iv.linux.org.uk, brauner@...nel.org,
 hansg@...nel.org, ilpo.jarvinen@...ux.intel.com
Cc: jack@...e.cz, linux-fsdevel@...r.kernel.org,
 linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH 0/4] platform/x86: wmi: Prepare for future changes

On 11/4/25 2:45 PM, Armin Wolf wrote:
> After over a year of reverse engineering, i am finally ready to
> introduce support for WMI-ACPI marshalling inside the WMI driver core.
marshaling> Since the resulting patch series is quite large, i am 
planning to
> submit the necessary patches as three separate patch series.
> 
> This is supposed to be the first of the three patch series. Its main
> purpose is to prepare the WMI driver core for the upcoming changes.
> The first patch fixes an issue inside the nls utf16 to utf8 conversion
> code, while the next two patches fix some minor issues inside the WMI
> driver core itself. The last patch finally moves the code of the WMI
> driver core into a separate repository to allow for future additions
> without cluttering the main directory.

One question I have here on the patch to move things.

Since Windows on ARM (WoA) laptops are a thing - is this still actually 
x86 specific?  I am wondering if this should be moving to a different 
subsystem altogether like ACPI; especially now with this impending other 
large patch series you have on your way.
> 
> Armin Wolf (4):
>    fs/nls: Fix utf16 to utf8 conversion
>    platform/x86: wmi: Use correct type when populating ACPI objects
>    platform/x86: wmi: Remove extern keyword from prototypes
>    platform/x86: wmi: Move WMI core code into a separate directory
> 
>   Documentation/driver-api/wmi.rst           |  2 +-
>   MAINTAINERS                                |  2 +-
>   drivers/platform/x86/Kconfig               | 30 +------------------
>   drivers/platform/x86/Makefile              |  2 +-
>   drivers/platform/x86/wmi/Kconfig           | 34 ++++++++++++++++++++++
>   drivers/platform/x86/wmi/Makefile          |  8 +++++
>   drivers/platform/x86/{wmi.c => wmi/core.c} | 34 +++++++++++++---------
>   fs/nls/nls_base.c                          | 16 +++++++---
>   include/linux/wmi.h                        | 15 ++++------
>   9 files changed, 84 insertions(+), 59 deletions(-)
>   create mode 100644 drivers/platform/x86/wmi/Kconfig
>   create mode 100644 drivers/platform/x86/wmi/Makefile
>   rename drivers/platform/x86/{wmi.c => wmi/core.c} (98%)
> 

Reviewed-by: Mario Limonciello (AMD) <superm1@...nel.org>