linux-kernel - Re: [RFC RFT PATCH] ocfs2: Mark inode bad upon validation failure during read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHxJ8O9Yci6QzGckrsWhuoDHatYyOOok++ySmYc43WbEhFy3xg@mail.gmail.com>
Date: Wed, 5 Nov 2025 01:31:01 +0300
From: Ahmet Eray Karadag <eraykrdg1@...il.com>
To: ocfs2-devel@...ts.linux.dev
Cc: Albin Babu Varghese <albinbabuvarghese20@...il.com>, mark@...heh.com, jlbec@...lplan.org, 
	joseph.qi@...ux.alibaba.com, linux-kernel@...r.kernel.org, 
	Heming Zhao <heming.zhao@...e.com>, david.hunter.linux@...il.com, 
	skhan@...uxfoundation.org, 
	syzbot+b93b65ee321c97861072@...kaller.appspotmail.com
Subject: Re: [RFC RFT PATCH] ocfs2: Mark inode bad upon validation failure
 during read

Hi folks,

I'm having some trouble getting xfstests-dev set up to test some ocfs2
changes. I can't seem to get the configuration working correctly to run
the ocfs2 test group.

Could anyone share some insights or pointers on the proper setup? Any
help would be much appreciated.

Cheers,
Ahmet Eray

Albin Babu Varghese <albinbabuvarghese20@...il.com>, 31 Eki 2025 Cum,
17:22 tarihinde şunu yazdı:
>
> > > > I support adding make_bad_inode() in ocfs2_read_inode_block_full().
> > > > ocfs2_read_locked_inode() calls ocfs2_read_inode_block[_full] to read the inode
> > > > from disk. However, ocfs2_read_inode_block[_full] have many callers, and in
> > > > current code, only ocfs2_read_locked_inode() marks the inode as bad. All others
> > > > forget to set the bad_inode.
> > > >
> > > > The 'forbid' write operations when read-only mode is worth another patch, and
> > > > I plan to create this patch. This patch adds a similar ext4_emergency_state()
> > > > function for ocfs2.
> > >
> > > We're working on this as part of the Linux Kernel Mentorship Program, and we'd
> > > love to take on implementing the read-only check if it's not overly
> > > complicated. We're just beginners, but we thought it would be a great learning
> > > experience to work on this following the ext4 pattern you mentioned - if you
> > > haven't already started working on it by the time you see this reply.
> >
> > I haven't started the patch job, you are welcome to take it.
>
> Thank you! We'll work on it and send the patch for review.
>
> Cheers,
>         Albin