linux-kernel - Re: [PATCH v2] media: iris: Refine internal buffer reconfiguration logic for resolution change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7d26e4e9-e298-4991-883f-ceb60f240394@packett.cool>
Date: Tue, 4 Nov 2025 20:50:20 -0300
From: Val Packett <val@...kett.cool>
To: Dikshita Agarwal <dikshita.agarwal@....qualcomm.com>,
 Vikash Garodia <vikash.garodia@....qualcomm.com>,
 Abhinav Kumar <abhinav.kumar@...ux.dev>, Bryan O'Donoghue <bod@...nel.org>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Hans Verkuil <hverkuil@...nel.org>,
 Stefan Schmidt <stefan.schmidt@...aro.org>
Cc: linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] media: iris: Refine internal buffer reconfiguration
 logic for resolution change


On 11/4/25 2:11 AM, Dikshita Agarwal wrote:
> [..]
> --- a/drivers/media/platform/qcom/iris/iris_common.c
> +++ b/drivers/media/platform/qcom/iris/iris_common.c
> @@ -91,12 +91,13 @@ int iris_process_streamon_input(struct iris_inst *inst)
>   int iris_process_streamon_output(struct iris_inst *inst)
>   {
>   	const struct iris_hfi_command_ops *hfi_ops = inst->core->hfi_ops;
> -	bool drain_active = false, drc_active = false;
>   	enum iris_inst_sub_state clear_sub_state = 0;
>   	int ret = 0;
>
> [..]

Somehow, you have lost the + edited line that declares the bools.. Hence 
the CI failure reported for v1, and the kernel test robot message from 
just a couple minutes ago.

But with `bool first_ipsc = false, drain_active = false, drc_active = 
false;` filled in,

Tested-by: Val Packett <val@...kett.cool>

finally the decoder is actually usable \o/

~val