linux-kernel - Re: [PATCH] firmware: stratix10-rsu: replace scnprintf() with sysfs_emit() in *

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <26032cb1-53c6-46a1-b3eb-e1876142bf1c@kernel.org>
Date: Mon, 3 Nov 2025 22:45:05 -0600
From: Dinh Nguyen <dinguyen@...nel.org>
To: Rahul Kumar <rk0006818@...il.com>
Cc: linux-kernel@...r.kernel.org, linux-kernel-mentees@...ts.linux.dev,
 skhan@...uxfoundation.org
Subject: Re: [PATCH] firmware: stratix10-rsu: replace scnprintf() with
 sysfs_emit() in *_show() functions



On 11/2/25 23:55, Rahul Kumar wrote:
> On Wed, Oct 15, 2025 at 3:11 PM Rahul Kumar <rk0006818@...il.com> wrote:
>>
>> Replace scnprintf() with sysfs_emit() in sysfs *_show() functions
>> in stratix10-rsu.c to follow the kernel's guidelines from
>> Documentation/filesystems/sysfs.rst.
>>
>> This improves consistency, safety, and makes the code easier to
>> maintain and update in the future.
>>
>> Signed-off-by: Rahul Kumar <rk0006818@...il.com>
>> ---
>>   drivers/firmware/stratix10-rsu.c | 7 +++----
>>   1 file changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/firmware/stratix10-rsu.c b/drivers/firmware/stratix10-rsu.c
>> index 1ea39a0a76c7..53c896ceca9a 100644
>> --- a/drivers/firmware/stratix10-rsu.c
>> +++ b/drivers/firmware/stratix10-rsu.c
>> @@ -454,8 +454,7 @@ static ssize_t max_retry_show(struct device *dev,
>>          if (!priv)
>>                  return -ENODEV;
>>
>> -       return scnprintf(buf, sizeof(priv->max_retry),
>> -                        "0x%08x\n", priv->max_retry);
>> +       return sysfs_emit(buf, "0x%08x\n", priv->max_retry);
>>   }
>>
>>   static ssize_t dcmf0_show(struct device *dev,
>> @@ -632,7 +631,7 @@ static ssize_t spt0_address_show(struct device *dev,
>>          if (priv->spt0_address == INVALID_SPT_ADDRESS)
>>                  return -EIO;
>>
>> -       return scnprintf(buf, PAGE_SIZE, "0x%08lx\n", priv->spt0_address);
>> +       return sysfs_emit(buf, "0x%08lx\n", priv->spt0_address);
>>   }
>>
>>   static ssize_t spt1_address_show(struct device *dev,
>> @@ -646,7 +645,7 @@ static ssize_t spt1_address_show(struct device *dev,
>>          if (priv->spt1_address == INVALID_SPT_ADDRESS)
>>                  return -EIO;
>>
>> -       return scnprintf(buf, PAGE_SIZE, "0x%08lx\n", priv->spt1_address);
>> +       return sysfs_emit(buf, "0x%08lx\n", priv->spt1_address);
>>   }
>>
>>   static DEVICE_ATTR_RO(current_image);
>> --
>> 2.43.0
>>
> 
> Hi Dinguyen,
> 
> Just following up to see if you’ve had a chance to review this patch,
> or if there’s anything more needed from my side.
> 
> Link to v1:
> https://lore.kernel.org/all/20251015094117.535157-1-rk0006818@gmail.com/
> 
> Thanks,
> Rahul

Sorry about that. I've applied it.

Thanks,
Dinh