linux-kernel - [PATCH net-next v3 1/4] dt-bindings: net: ftgmac100: Add delay properties for AST2600

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SEYPR06MB5134AB242733717317AAEDEA9DC4A@SEYPR06MB5134.apcprd06.prod.outlook.com>
Date: Tue, 4 Nov 2025 05:14:41 +0000
From: Jacky Chou <jacky_chou@...eedtech.com>
To: Andrew Lunn <andrew@...n.ch>
CC: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring
	<robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
	<conor+dt@...nel.org>, Po-Yu Chuang <ratbert@...aday-tech.com>, Joel Stanley
	<joel@....id.au>, Andrew Jeffery <andrew@...econstruct.com.au>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
	<linux-aspeed@...ts.ozlabs.org>, "taoren@...a.com" <taoren@...a.com>
Subject: [PATCH net-next v3 1/4] dt-bindings: net: ftgmac100: Add delay
 properties for AST2600

Hi Andrew,

Thank you for your reply.

> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: aspeed,ast2600-mac01
> > +    then:
> > +      properties:
> > +        rx-internal-delay-ps:
> > +          minimum: 0
> > +          maximum: 1395
> > +          multipleOf: 45
> 
> I would add a default: 0
> 

Agreed.
I will add it in next version.

> > +        tx-internal-delay-ps:
> > +          minimum: 0
> > +          maximum: 1395
> > +          multipleOf: 45
> 
> and also here.
> 

Agreed.

> > +      required:
> > +        - scu
> > +        - rx-internal-delay-ps
> > +        - tx-internal-delay-ps
> 
> and then these are not required, but optional.
> 

Configure the tx/rx delay in the scu register.
At least, the scu handle must be required.

Here I have one question.
In v3 patches series, if the ftgmac driver cannot find one of 
tx-internal-delay-ps and rx-internal-delay-ps, it will return error in probe 
stage.
If here is optional, does it means that just add warning and not return error when
lack one of them and use the default to configure? Or not configure tx/rx delay just
return success in probe stage?

Thanks,
Jacky