linux-kernel - Re: [PATCH v2 1/2] dt-bindings: leds: backlight: Add Awinic AW99706 backlight

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251104-dancing-panda-of-patience-49bcc7@kuoka>
Date: Tue, 4 Nov 2025 08:30:36 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Junjie Cao <caojunjie650@...il.com>
Cc: Lee Jones <lee@...nel.org>, Daniel Thompson <danielt@...nel.org>, 
	Jingoo Han <jingoohan1@...il.com>, Pavel Machek <pavel@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Helge Deller <deller@....de>, 
	dri-devel@...ts.freedesktop.org, linux-leds@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-fbdev@...r.kernel.org, Pengyu Luo <mitltlatltl@...il.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: leds: backlight: Add Awinic AW99706
 backlight

On Mon, Nov 03, 2025 at 07:06:47PM +0800, Junjie Cao wrote:
> From: Pengyu Luo <mitltlatltl@...il.com>
> 
> Add Awinic AW99706 backlight binding documentation.
> 
> Signed-off-by: Junjie Cao <caojunjie650@...il.com>

Messed DCO chain. This wasn't here, so you must have altered v1 to add
some weird change.

This is a blocker, please read carefully submitting patches and DCO.

> ---
> Changes in v2:
> - use proper units for properties (Krzysztof)
> - drop non-fixed properties (Krzysztof)
> - add properties(max-brightness, default-brightness) (Krzysztof)
> - Link to v1: https://lore.kernel.org/linux-leds/20251026123923.1531727-2-caojunjie650@gmail.com

...

> +  awinic,dim-mode:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: >
> +      Select dimming mode of the device.
> +        0 = Bypass mode.
> +        1 = DC mode.
> +        2 = MIX mode(PWM at low brightness and DC at high brightness).
> +        3 = MIX-26k mode(MIX mode with different PWM frequency).
> +    enum: [ 0, 1, 2, 3 ]
> +    default: 1
> +
> +  awinic,sw-freq-hz:
> +    description: Boost switching frequency in Hz.
> +    enum: [ 300000, 400000, 500000, 600000, 660000, 750000, 850000, 1000000, 1200000, 1330000, 1500000, 1700000 ]

Please wrap code according to the preferred limit expressed in Kernel
coding style (checkpatch is not a coding style description, but only a
tool).

> +    default: 750000
> +
> +  awinic,sw-ilmt-microamp:
> +    description: Switching current limitation in uA.
> +    enum: [ 1500000, 2000000, 2500000, 3000000 ]
> +    default: 3000000
> +
> +  awinic,iled-max-microamp:
> +    description: Maximum LED current setting in uA.
> +    minimum: 5000
> +    maximum: 50000
> +    multipleOf: 500
> +    default: 20000
> +
> +  awinic,uvlo-thres-microvolt:
> +    description: UVLO(Under Voltage Lock Out) in uV.
> +    enum: [ 2200000, 5000000 ]
> +    default: 2200000
> +
> +  awinic,ramp-ctl:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: >
> +      Select ramp control and filter of the device.
> +        0 = Fade in/fade out.
> +        1 = Light filter.
> +        2 = Medium filter.
> +        3 = Heavy filter.
> +    enum: [ 0, 1, 2, 3 ]
> +    default: 2
> +
> +required:
> +  - compatible
> +  - reg
> +  - enable-gpios
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        aw99706@76 {

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
If you cannot find a name matching your device, please check in kernel
sources for similar cases or you can grow the spec (via pull request to
DT spec repo).

> +            compatible = "awinic,aw99706";
> +            reg = <0x76>;
> +            enable-gpios = <&tlmm 88 GPIO_ACTIVE_HIGH>;
> +            default-brightness = <2047>;
> +            max-brightness = <4095>;
> +            awinic,dim-mode = <1>;
> +            awinic,sw-freq-hz = <750000>;
> +            awinic,sw-ilmt-microamp = <3000000>;
> +            awinic,uvlo-thres-microvolt = <2200000>;
> +            awinic,iled-max-microamp = <20000>;
> +            awinic,ramp-ctl = <2>;
> +        };
> +    };
> +
> +...
> -- 
> 2.51.1.dirty
>