[<prev] [next>] [day] [month] [year] [list]
Message-Id: <20251104073305.299-1-weishangjuan@eswincomputing.com>
Date: Tue, 4 Nov 2025 15:33:05 +0800
From: weishangjuan@...incomputing.com
To: devicetree@...r.kernel.org,
andrew+netdev@...n.ch,
davem@...emloft.net,
edumazet@...gle.com,
kuba@...nel.org,
pabeni@...hat.com,
robh@...nel.org,
krzk+dt@...nel.org,
conor+dt@...nel.org,
netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Cc: ningyu@...incomputing.com,
linmin@...incomputing.com,
lizhi2@...incomputing.com,
pinkesh.vaghela@...fochips.com,
Shangjuan Wei <weishangjuan@...incomputing.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: [PATCH net-next v2] dt-bindings: ethernet: eswin: fix yaml schema issues
From: Shangjuan Wei <weishangjuan@...incomputing.com>
eswin,hsp-sp-csr attribute is one phandle with multiple arguments,
so the syntax should be in the form of:
items:
- items:
- description: ...
- description: ...
- description: ...
- description: ...
To align with the description of the 'eswin-sp-csr'
attribute in the mmc,usb modules, the description
of the 'eswin,hsp-sp-csr' attribute has been modified.
Fixes: 888bd0eca93c ("dt-bindings: ethernet: eswin: Document for EIC7700 SoC")
Reported-by: Rob Herring (Arm) <robh@...nel.org>
Closes: https://lore.kernel.org/all/176096011380.22917.1988679321096076522.robh@kernel.org/
Signed-off-by: Shangjuan Wei <weishangjuan@...incomputing.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
---
Changes in v2:
- Simplified problem description
- Add a space after the commit ID
- Add subject prefix
- Link to v1:
https://lore.kernel.org/all/20251030085001.191-1-weishangjuan@eswincomputing.com/
---
.../bindings/net/eswin,eic7700-eth.yaml | 20 ++++++++++---------
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml b/Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml
index 9ddbfe219ae2..91e8cd1db67b 100644
--- a/Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml
+++ b/Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml
@@ -69,17 +69,19 @@ properties:
enum: [0, 200, 600, 1200, 1600, 1800, 2000, 2200, 2400]
eswin,hsp-sp-csr:
+ description:
+ HSP CSR is to control and get status of different high-speed peripherals
+ (such as Ethernet, USB, SATA, etc.) via register, which can tune
+ board-level's parameters of PHY, etc.
$ref: /schemas/types.yaml#/definitions/phandle-array
items:
- - description: Phandle to HSP(High-Speed Peripheral) device
- - description: Offset of phy control register for internal
- or external clock selection
- - description: Offset of AXI clock controller Low-Power request
- register
- - description: Offset of register controlling TX/RX clock delay
- description: |
- High-Speed Peripheral device needed to configure clock selection,
- clock low-power mode and clock delay.
+ - items:
+ - description: Phandle to HSP(High-Speed Peripheral) device
+ - description: Offset of phy control register for internal
+ or external clock selection
+ - description: Offset of AXI clock controller Low-Power request
+ register
+ - description: Offset of register controlling TX/RX clock delay
required:
- compatible
--
2.17.1
Powered by blists - more mailing lists