linux-kernel - Re: [PATCH 1/2] dt-bindings: spi: Document imx94 xspi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251104-cerise-muskrat-of-teaching-873ade@kuoka>
Date: Tue, 4 Nov 2025 08:39:10 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Haibo Chen <haibo.chen@....com>
Cc: Han Xu <han.xu@....com>, Mark Brown <broonie@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, linux-spi@...r.kernel.org, imx@...ts.linux.dev, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: spi: Document imx94 xspi

On Tue, Nov 04, 2025 at 11:07:36AM +0800, Haibo Chen wrote:
> Document imx94 xspi that supports interface to serial flash
> supporting following features:
> 
> - Single-bit SPI, Dual SPI, Quad SPI and Octal SPI.
> - Single Data Rate or Double Data Rate modes.
> - Direct memory mapping of all AHB memory accesses to the
>   chip system memory space.
> - Multi-master AHB accesses with priority.
> 
> Signed-off-by: Haibo Chen <haibo.chen@....com>
> ---
>  .../devicetree/bindings/spi/spi-nxp-xspi.yaml      | 84 ++++++++++++++++++++++
>  MAINTAINERS                                        |  8 +++
>  2 files changed, 92 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/spi-nxp-xspi.yaml b/Documentation/devicetree/bindings/spi/spi-nxp-xspi.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..36970514036fe8e776908a15ed1ea2b21f2c4c9a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/spi-nxp-xspi.yaml

Filename matching exactly compatible (we asked this multiple times
already in other patchsets from NXP).

> @@ -0,0 +1,84 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/spi/spi-nxp-xspi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP External Serial Peripheral Interface (xSPI)
> +
> +maintainers:
> +  - Haibo Chen <haibo.chen@....com>
> +  - Han Xu <han.xu@....com>
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - enum:
> +          - nxp,imx94-xspi
> +
> +  reg:
> +    items:
> +      - description: registers address space
> +      - description: memory mapped address space
> +
> +  reg-names:
> +    items:
> +      - const: base
> +      - const: mmap
> +
> +  interrupts:
> +    maxItems: 5
> +
> +  clocks:
> +    items:
> +      - description: SPI serial clock
> +
> +  clock-names:
> +    items:
> +      - const: per
> +
> +required:
> +  - compatible
> +  - reg
> +  - reg-names
> +  - interrupts
> +  - clocks
> +  - clock-names
> +
> +allOf:
> +  - $ref: spi-controller.yaml#
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +    soc {
> +        #address-cells = <2>;
> +        #size-cells = <2>;
> +
> +        spi@...90000 {
> +            compatible = "nxp,imx943-xspi";

That's not what your schema said.

> +            reg = <0x42b90000 0x50000>, <0x28000000 0x08000000>;
> +            reg-names = "base", "mmap";
> +            interrupts = <GIC_SPI 390 IRQ_TYPE_LEVEL_HIGH>,
> +                         <GIC_SPI 391 IRQ_TYPE_LEVEL_HIGH>,
> +                         <GIC_SPI 392 IRQ_TYPE_LEVEL_HIGH>,
> +                         <GIC_SPI 393 IRQ_TYPE_LEVEL_HIGH>,
> +                         <GIC_SPI 394 IRQ_TYPE_LEVEL_HIGH>;
> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +            clocks = <&scmi_1>;
> +            clock-names = "per";
> +
> +            flash@0 {
> +                compatible = "jedec,spi-nor";
> +                reg = <0>;
> +                spi-max-frequency = <200000000>;
> +                spi-rx-bus-width = <8>;
> +                spi-tx-bus-width = <8>;
> +            };
> +

Drop blank line

> +        };

Best regards,
Krzysztof