linux-kernel - Re: [PATCH v2 3/5] media: qcom: iris: Add rotation support for encoder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bd1cfdac-16ea-46d7-ab97-989a2d3ff203@oss.qualcomm.com>
Date: Tue, 4 Nov 2025 15:48:47 +0800
From: Wangao Wang <wangao.wang@....qualcomm.com>
To: Neil Armstrong <neil.armstrong@...aro.org>,
        Vikash Garodia <vikash.garodia@....qualcomm.com>,
        Dikshita Agarwal <dikshita.agarwal@....qualcomm.com>,
        Abhinav Kumar <abhinav.kumar@...ux.dev>,
        Bryan O'Donoghue <bod@...nel.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Cc: linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org, quic_qiweil@...cinc.com,
        quic_renjiang@...cinc.com
Subject: Re: [PATCH v2 3/5] media: qcom: iris: Add rotation support for
 encoder

On 10/31/2025 7:30 PM, Neil Armstrong wrote:
> 
> I found the issue with SM8650, you did not update the vppu33 variant of 
> iris_vpu_enc_line_size.
> 
> With this:
> ============================><=============================
> diff --git a/drivers/media/platform/qcom/iris/iris_vpu_buffer.c b/ 
> drivers/media/platform/qcom/iris/iris_vpu_buffer.c
> index be8b8588a39f..4a4fbcbfdb46 100644
> --- a/drivers/media/platform/qcom/iris/iris_vpu_buffer.c
> +++ b/drivers/media/platform/qcom/iris/iris_vpu_buffer.c
> @@ -1082,8 +1082,8 @@ static u32 iris_vpu33_enc_line_size(struct 
> iris_inst *inst)
>   {
>          u32 num_vpp_pipes = inst->core->iris_platform_data->num_vpp_pipe;
>          struct v4l2_format *f = inst->fmt_dst;
> -       u32 height = f->fmt.pix_mp.height;
> -       u32 width = f->fmt.pix_mp.width;
> +       u32 height = iris_vpu_enc_get_bitstream_height(inst);
> +       u32 width = iris_vpu_enc_get_bitstream_width(inst);
>          u32 lcu_size = 16;
> 
>          if (inst->codec == V4L2_PIX_FMT_HEVC) {
> ============================><=============================
> 
> Tested-by: Neil Armstrong <neil.armstrong@...aro.org> # on SM8650-HDK
> 
> Neil
> 
> 
> <snip>
> 
Thank you for helping test on SM8650.
I indeed forgot to add the corresponding changes here.
This issue will be addressed in v3.

-- 
Best Regards,
Wangao