linux-kernel - Re: [PATCH] md/raid5: remove redundant __GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALTww29GVOw3sk2=A_9dj5QMGtfogRjxRsunc1D74AqLFj_MyA@mail.gmail.com>
Date: Tue, 4 Nov 2025 16:04:47 +0800
From: Xiao Ni <xni@...hat.com>
To: Huiwen He <hehuiwen@...inos.cn>
Cc: Song Liu <song@...nel.org>, Yu Kuai <yukuai3@...wei.com>, linux-raid@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] md/raid5: remove redundant __GFP_NOWARN

On Sun, Nov 2, 2025 at 11:27 PM Huiwen He <hehuiwen@...inos.cn> wrote:
>
> The __GFP_NOWARN flag was included in GFP_NOWAIT since commit
> 16f5dfbc851b ("gfp: include __GFP_NOWARN in GFP_NOWAIT"). So
> remove the redundant __GFP_NOWARN flag.
>
> Signed-off-by: Huiwen He <hehuiwen@...inos.cn>
> ---
>  drivers/md/raid5-cache.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c
> index ba768ca7f422..e29e69335c69 100644
> --- a/drivers/md/raid5-cache.c
> +++ b/drivers/md/raid5-cache.c
> @@ -3104,7 +3104,7 @@ int r5l_init_log(struct r5conf *conf, struct md_rdev *rdev)
>                 goto out_mempool;
>
>         spin_lock_init(&log->tree_lock);
> -       INIT_RADIX_TREE(&log->big_stripe_tree, GFP_NOWAIT | __GFP_NOWARN);
> +       INIT_RADIX_TREE(&log->big_stripe_tree, GFP_NOWAIT);
>
>         thread = md_register_thread(r5l_reclaim_thread, log->rdev->mddev,
>                                     "reclaim");
> --
> 2.25.1
>
>

Hi

It still has other places that use __GFP_NOWARN in raid5.c, do you
want to remove it together?

Anyway, the patch looks good to me.
Reviewed-by: Xiao Ni <xni@...hat.com>