linux-kernel - Re: [PATCH v3 1/2] dt-bindings: soc: qcom: Add qcom,kaanapali-imem compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251104-glaring-rebel-pillbug-a467ca@kuoka>
Date: Tue, 4 Nov 2025 09:16:57 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jingyi Wang <jingyi.wang@....qualcomm.com>
Cc: Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Bjorn Andersson <andersson@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>, 
	Robert Marko <robimarko@...il.com>, Das Srinagesh <quic_gurus@...cinc.com>, 
	aiqun.yu@....qualcomm.com, tingwei.zhang@....qualcomm.com, trilok.soni@....qualcomm.com, 
	yijie.yang@....qualcomm.com, linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: soc: qcom: Add qcom,kaanapali-imem
 compatible

On Sun, Nov 02, 2025 at 11:25:06PM -0800, Jingyi Wang wrote:
> Document qcom,kaanapali-imem compatible. Kaanapali IMEM is not a syscon or
> simple-mfd, also "reboot reason" is not required on Kaanapali like some

I do not see correlation. Something is not a syscon, so you add a new
generic compatible? No.

> other platforms. So define a common "qcom,imem" binding and fallback to it.

You did not define fallback to it!

...

> +      - items:
> +          - enum:
> +              - qcom,kaanapali-imem
> +          - const: qcom,imem

I do not understand what this generic compatible is supposed to express,
not explained in commit msg. Considering this wasn't before, it is a
major and really undesired change. It also makes no sesne. There was no
generic compatible before but "if not syscon" now this must have generic
compatible, what?

NAK

Best regards,
Krzysztof