linux-kernel - Re: [PATCH v3 06/20] dt-bindings: mfd: samsung,s2mpg10: Add s2mpg11-pmic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251104-glossy-frog-of-grandeur-a345d1@kuoka>
Date: Tue, 4 Nov 2025 09:37:23 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: André Draszik <andre.draszik@...aro.org>
Cc: Tudor Ambarus <tudor.ambarus@...aro.org>, 
	Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, Lee Jones <lee@...nel.org>, 
	Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Peter Griffin <peter.griffin@...aro.org>, 
	Will McVicker <willmcvicker@...gle.com>, kernel-team@...roid.com, linux-kernel@...r.kernel.org, 
	linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org, linux-gpio@...r.kernel.org
Subject: Re: [PATCH v3 06/20] dt-bindings: mfd: samsung,s2mpg10: Add
 s2mpg11-pmic

On Mon, Nov 03, 2025 at 07:14:45PM +0000, André Draszik wrote:
> +  "^vinb[abd]-supply$":
> +    description: |
> +      Phandle to the power supply for the additional buck rails of the S2MPG11
> +      PMIC. The mapping of supply to rail is as follows::
> +        vinba - bucka
> +        vinbb - buck boost
> +        vinbd - buckd
> +
> +  "^vinl[1-6]s-supply$":
> +    description: |
> +      Phandle to the power supply for one or multiple LDO rails of the S2MPG11
> +      PMIC. The mapping of supply to rail(s) is as follows:
> +        vinl1s - ldo1s, ldo2s
> +        vinl2s - ldo8s, ldo9s
> +        vinl3s - ldo3s, ldo5s, ldo7s, ldo15s
> +        vinl4s - ldo10s, ldo11s, ldo12s, ldo14s
> +        vinl5s - ldo4s, ldo6s
> +        vinl6s - ldo13s
> +
>  required:
>    - compatible
>    - interrupts
> @@ -81,3 +102,23 @@ allOf:
>        properties:
>          regulators:
>            $ref: /schemas/regulator/samsung,s2mpg10-regulator.yaml
> +
> +      patternProperties:
> +        "[^m]-supply$": false
> +
> +  - if:

OK, so this explains why earlier you put $ref in if:then:. I propose to
move it to separate new MFD schema, because half or more of properties
are not applicable between each of the devices.


Best regards,
Krzysztof