linux-kernel - Re: [PATCH 16/22] selftests/coredump: handle edge-triggered epoll correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJqdLrr25D+-M0kPhFkh-7pp1J3Z3B21DhfQaXOvTEN-3D3LQA@mail.gmail.com>
Date: Tue, 4 Nov 2025 10:12:59 +0100
From: Alexander Mikhalitsyn <alexander@...alicyn.com>
To: Christian Brauner <brauner@...nel.org>
Cc: linux-fsdevel@...r.kernel.org, Oleg Nesterov <oleg@...hat.com>, 
	Amir Goldstein <amir73il@...il.com>, Aleksa Sarai <cyphar@...har.com>, 
	Yu Watanabe <watanabe.yu+github@...il.com>, Josef Bacik <josef@...icpanda.com>, 
	Jeff Layton <jlayton@...nel.org>, Jann Horn <jannh@...gle.com>, 
	Luca Boccassi <luca.boccassi@...il.com>, linux-kernel@...r.kernel.org, 
	Alexander Viro <viro@...iv.linux.org.uk>, Jan Kara <jack@...e.cz>, 
	Lennart Poettering <lennart@...ttering.net>, Mike Yuan <me@...dnzj.com>, 
	Zbigniew Jędrzejewski-Szmek <zbyszek@...waw.pl>
Subject: Re: [PATCH 16/22] selftests/coredump: handle edge-triggered epoll correctly

Am Di., 28. Okt. 2025 um 09:47 Uhr schrieb Christian Brauner
<brauner@...nel.org>:
>
> by putting the file descriptor into non-blocking mode.
>
> Signed-off-by: Christian Brauner <brauner@...nel.org>

Reviewed-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@...onical.com>

> ---
>  tools/testing/selftests/coredump/coredump_test_helpers.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/tools/testing/selftests/coredump/coredump_test_helpers.c b/tools/testing/selftests/coredump/coredump_test_helpers.c
> index 7512a8ef73d3..116c797090a1 100644
> --- a/tools/testing/selftests/coredump/coredump_test_helpers.c
> +++ b/tools/testing/selftests/coredump/coredump_test_helpers.c
> @@ -291,6 +291,14 @@ void process_coredump_worker(int fd_coredump, int fd_peer_pidfd, int fd_core_fil
>         int epfd = -1;
>         int exit_code = EXIT_FAILURE;
>         struct epoll_event ev;
> +       int flags;
> +
> +       /* Set socket to non-blocking mode for edge-triggered epoll */
> +       flags = fcntl(fd_coredump, F_GETFL, 0);
> +       if (flags < 0)
> +               goto out;
> +       if (fcntl(fd_coredump, F_SETFL, flags | O_NONBLOCK) < 0)
> +               goto out;
>
>         epfd = epoll_create1(0);
>         if (epfd < 0)
>
> --
> 2.47.3
>