linux-kernel - Re: [PATCH net-next 3/3] net: phy: dp83869: Support 1000Base-X SFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e2541569-bfee-4548-a399-af2e43c7a53a@bootlin.com>
Date: Tue, 4 Nov 2025 10:15:45 +0100
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Romain Gantois <romain.gantois@...tlin.com>,
 "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 3/3] net: phy: dp83869: Support 1000Base-X SFP

Hi,

On 04/11/2025 10:10, Romain Gantois wrote:
> On Tuesday, 4 November 2025 10:01:36 CET Russell King (Oracle) wrote:
>> On Tue, Nov 04, 2025 at 09:50:36AM +0100, Romain Gantois wrote:
>>> +static void dp83869_module_remove(void *upstream)
>>> +{
>>> +	struct phy_device *phydev = upstream;
>>> +
>>> +	phydev_info(phydev, "SFP module removed\n");
>>> +
>>> +	/* Set speed and duplex to unknown to avoid downshifting warning. */
>>> +	phydev->speed = SPEED_UNKNOWN;
>>> +	phydev->duplex = DUPLEX_UNKNOWN;
>>
>> Should this be done by core phylib code?
> 
> I guess that enough PHY drivers do this by hand that a new phylib helper could 
> be warranted. Maybe something like phy_clear_aneg_results(), which would set 
> speed, duplex, pause and asym_pause to default values.

Note that when phy_port eventually gets merged, we'll have a 
common .module_remove() for PHY SFP :

https://lore.kernel.org/netdev/20251013143146.364919-9-maxime.chevallier@bootlin.com/

We could definitely do that here :)

Maxime