linux-kernel - Re: [PATCH v1 1/1] base64: Unroll the tables initialisers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aQnK4jxPGOVsmjDt@smile.fi.intel.com>
Date: Tue, 4 Nov 2025 11:44:02 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: David Laight <david.laight.linux@...il.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
	Guan-Chun Wu <409411716@....tku.edu.tw>,
	Kuan-Wei Chiu <visitorckw@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] base64: Unroll the tables initialisers

On Tue, Nov 04, 2025 at 09:07:40AM +0000, David Laight wrote:
> On Tue, 4 Nov 2025 10:18:39 +0200
> Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
> > On Mon, Nov 03, 2025 at 10:18:57PM +0000, David Laight wrote:

...

> > > > +	[BASE64_STD] = {
> > > > +		0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,	/*   0 -   7 */  
> > > 
> > > You need to use -1 not 0xff.  
> > 
> > Whu? The s8 type is pretty much 8-bit, care to explain the point?
> 
> I think it is clang that complains that the value is out of range.

I use clang on daily basis to compile kernel and I definitely compiled
the proposal I sent. So, no, not this one.

-- 
With Best Regards,
Andy Shevchenko