linux-kernel - Re: [PATCH v3 1/2] dt-bindings: firmware: svc: Add IOMMU support for Agilex5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251104-bipedal-sheep-of-advertising-08450c@kuoka>
Date: Tue, 4 Nov 2025 10:48:22 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Khairul Anuar Romli <khairul.anuar.romli@...era.com>
Cc: Dinh Nguyen <dinguyen@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Mahesh Rao <mahesh.rao@...era.com>, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, 
	Adrian Ng Ho Yin <adrianhoyin.ng@...era.com>, Niravkumar L Rabara <niravkumarlaxmidas.rabara@...era.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: firmware: svc: Add IOMMU support for
 Agilex5

On Tue, Nov 04, 2025 at 07:39:27AM +0800, Khairul Anuar Romli wrote:
> In Agilex5, the TBU (Translation Buffer Unit) can now operate in non-secure
> mode, enabling Linux to utilize it through the IOMMU framework. This allows
> improved memory management capabilities in non-secure environments. With
> Agilex5 lifting this restriction, we are now extending the device tree
> bindings to support IOMMU for the Agilex5 SVC.
> 
> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@...era.com>
> Reviewed-by: Adrian Ng Ho Yin <adrianhoyin.ng@...era.com>
> Reviewed-by: Niravkumar L Rabara <niravkumarlaxmidas.rabara@...era.com>

Two reviews but...

>  
> -required:
> -  - compatible
> -  - method
> -  - memory-region
> +allOf:
> +  - required:
> +      - compatible
> +      - method
> +      - memory-region

... none told you this is not the correct syntax / style?

Were these reviews really happening? What exactly was reviewed here?

Best regards,
Krzysztof