linux-kernel - Re: [PATCH v2 1/7] drm: writeback: Refactor drm_writeback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d6545844-f7f6-4714-927f-cf985dc50a54@bootlin.com>
Date: Tue, 4 Nov 2025 11:24:17 +0100
From: Louis Chauvet <louis.chauvet@...tlin.com>
To: Suraj Kandpal <suraj.kandpal@...el.com>, linux-arm-msm@...r.kernel.org,
 freedreno@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
 intel-xe@...ts.freedesktop.org, intel-gfx@...ts.freedesktop.org,
 kernel-list@...pberrypi.com, amd-gfx@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Cc: dmitry.baryshkov@....qualcomm.com, ankit.k.nautiyal@...el.com,
 arun.r.murthy@...el.com, uma.shankar@...el.com, jani.nikula@...el.com,
 harry.wentland@....com, siqueira@...lia.com, alexander.deucher@....com,
 christian.koenig@....com, airlied@...il.com, simona@...ll.ch,
 liviu.dudau@....com, maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
 robin.clark@....qualcomm.com, abhinav.kumar@...ux.dev, tzimmermann@...e.de,
 jessica.zhang@....qualcomm.com, sean@...rly.run,
 marijn.suijten@...ainline.org, laurent.pinchart+renesas@...asonboard.com,
 mcanal@...lia.com, dave.stevenson@...pberrypi.com,
 tomi.valkeinen+renesas@...asonboard.com,
 kieran.bingham+renesas@...asonboard.com
Subject: Re: [PATCH v2 1/7] drm: writeback: Refactor drm_writeback_connector
 structure



Le 07/10/2025 à 07:45, Suraj Kandpal a écrit :
> Some drivers cannot work with the current design where the connector
> is embedded within the drm_writeback_connector such as Intel and
> some drivers that can get it working end up adding a lot of checks
> all around the code to check if it's a writeback conenctor or not,
> this is due to the limitation of inheritance in C.
> To solve this move the drm_writeback_connector within the
> drm_connector and remove the drm_connector base which was in
> drm_writeback_connector. Make this drm_writeback_connector
> a union with hdmi connector to save memory and since a connector can
> never be both writeback and hdmi it should serve us well.
> Do all other required modifications that come with these changes
> along with addition of new function which returns the drm_connector
> when drm_writeback_connector is present.
> Modify drivers using the drm_writeback_connector to
> allow them to use this connector without breaking them.
> The drivers modified here are amd, komeda, mali, vc4, vkms,
> rcar_du, msm
> 
> Signed-off-by: Suraj Kandpal <suraj.kandpal@...el.com>
> ---
> V1 -> V2: Use &connector->writeback, make commit message imperative (Dmitry)
> ---

[...]

>   drivers/gpu/drm/vkms/vkms_composer.c          |  2 +-
>   drivers/gpu/drm/vkms/vkms_drv.h               |  2 +-
>   drivers/gpu/drm/vkms/vkms_writeback.c         | 13 ++--

For the VKMS part:

Reviewed-by: Louis Chauvet <louis.chauvet@...tlin.com>

Thanks,
Louis Chauvet

--
Louis Chauvet, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com