linux-kernel - [PATCH] EDAC/ie31200: Fix error handling in ie31200_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20251104012317.34637-1-make24@iscas.ac.cn>
Date: Tue,  4 Nov 2025 09:23:17 +0800
From: Ma Ke <make24@...as.ac.cn>
To: jbaron@...mai.com,
	bp@...en8.de,
	tony.luck@...el.com,
	qiuxu.zhuo@...el.com
Cc: linux-edac@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org,
	Ma Ke <make24@...as.ac.cn>,
	stable@...r.kernel.org
Subject: [PATCH] EDAC/ie31200: Fix error handling in ie31200_register_mci

When mc > 0, ie31200_register_mci() initializes priv->dev but fails to
call put_device() on it in the error path, causing a memory leak. Add
proper put_device() call for priv->dev in the error handling path to
balance device_initialize().

Found by code review.

Cc: stable@...r.kernel.org
Fixes: d0742284ec6d ("EDAC/ie31200: Add Intel Raptor Lake-S SoCs support")
Signed-off-by: Ma Ke <make24@...as.ac.cn>
---
 drivers/edac/ie31200_edac.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/edac/ie31200_edac.c b/drivers/edac/ie31200_edac.c
index 5a080ab65476..a5a4bb24b72a 100644
--- a/drivers/edac/ie31200_edac.c
+++ b/drivers/edac/ie31200_edac.c
@@ -528,6 +528,8 @@ static int ie31200_register_mci(struct pci_dev *pdev, struct res_config *cfg, in
 fail_unmap:
 	iounmap(window);
 fail_free:
+	if (mc > 0)
+		put_device(&priv->dev);
 	edac_mc_free(mci);
 	return ret;
 }
-- 
2.17.1