linux-kernel - Re: [PATCH] dt-bindings: sram: qcom,imem: drop the IPQ5424 compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45a74411-32a0-4a28-a738-9f44d66c0de3@oss.qualcomm.com>
Date: Tue, 4 Nov 2025 13:48:55 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@....qualcomm.com>,
        Krzysztof Kozlowski <krzk@...nel.org>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: sram: qcom,imem: drop the IPQ5424 compatible

On 10/27/25 5:59 AM, Kathiravan Thirumoorthy wrote:
> 
> On 10/21/2025 12:32 PM, Krzysztof Kozlowski wrote:
>> On Wed, Oct 15, 2025 at 11:46:58AM +0530, Kathiravan Thirumoorthy wrote:
>>> Based on the recent discussion in the linux-arm-msm list[1], it is not
>>> appropriate to define the IMEM (On-Chip SRAM) as syscon or MFD. Since
>>> there are no consumers of this compatible, drop it and move to
>>> mmio-sram.
>>>
>>> While at it, add a comment to not to extend the list and move towards
>>> mmio-sram.
>>>
>>> [1] https://lore.kernel.org/linux-arm-msm/e4c5ecc3-fd97-4b13-a057-bb1a3b7f9207@kernel.org/
>>>
>>> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@....qualcomm.com>
>>> ---
>>>   Documentation/devicetree/bindings/sram/qcom,imem.yaml | 3 +--
>>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/sram/qcom,imem.yaml b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
>>> index 6a627c57ae2fecdbb81cae710f6fb5e48156b1f5..3147f3634a531514a670e714f3878e5375db7285 100644
>>> --- a/Documentation/devicetree/bindings/sram/qcom,imem.yaml
>>> +++ b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
>>> @@ -14,11 +14,10 @@ description:
>>>     transactions.
>>>     properties:
>>> -  compatible:
>>> +  compatible: # Don't grow this list. Please use mmio-sram if possible
>>>       items:
>>>         - enum:
>>>             - qcom,apq8064-imem
>>> -          - qcom,ipq5424-imem
>> And where is qcom,ipq5424-imem added? This is supposed to be one patch.
> 
> 
> Kindly excuse for the delay in the response as I was out of work.
> 
> This is supposed to be added in the sram.yaml binding, but I haven't completed that yet. Between Konrad has done some rework [1] on removing the imem.yaml and combined with sram.yaml (in his dev tree). So I hope it will be taken care along with that.
> 
> Konrad, Can you help to share the plan on when the patches will be posted for review? It will be helpful for reviving my other series[2] and obviously yours too :)
> 
> [1] https://github.com/quic-kdybcio/linux/commits/topic/imem_sram/
> 
> [2] https://lore.kernel.org/linux-arm-msm/20250610-wdt_reset_reason-v5-0-2d2835160ab5@oss.qualcomm.com/#t

Let's get an answer on the Kaanapali thread and go from there

https://lore.kernel.org/linux-arm-msm/176222838026.1146775.13955186005277266199.b4-ty@kernel.org/T/#mb3284a3a0bc3a9cda9cc6c0fb9433e8c2dddea2f

Konrad