linux-kernel - [PATCH v4 3/8] net: stmmac: qcom-ethqos: improve typing in devres callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20251104-qcom-sa8255p-emac-v4-3-f76660087cea@linaro.org>
Date: Tue, 04 Nov 2025 14:08:54 +0100
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Bjorn Andersson <andersson@...nel.org>, 
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Conor Dooley <conor+dt@...nel.org>, 
 Richard Cochran <richardcochran@...il.com>, 
 Andrew Lunn <andrew+netdev@...n.ch>, 
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
 Maxime Coquelin <mcoquelin.stm32@...il.com>, 
 Alexandre Torgue <alexandre.torgue@...s.st.com>, 
 Vinod Koul <vkoul@...nel.org>, Giuseppe Cavallaro <peppe.cavallaro@...com>, 
 Jose Abreu <joabreu@...opsys.com>, Chen-Yu Tsai <wens@...nel.org>, 
 Jernej Skrabec <jernej.skrabec@...il.com>, 
 Samuel Holland <samuel@...lland.org>, 
 Matthew Gerlach <matthew.gerlach@...era.com>, 
 Neil Armstrong <neil.armstrong@...aro.org>, 
 Kevin Hilman <khilman@...libre.com>, Jerome Brunet <jbrunet@...libre.com>, 
 Martin Blumenstingl <martin.blumenstingl@...glemail.com>, 
 Keguang Zhang <keguang.zhang@...il.com>, Shawn Guo <shawnguo@...nel.org>, 
 Sascha Hauer <s.hauer@...gutronix.de>, 
 Pengutronix Kernel Team <kernel@...gutronix.de>, 
 Fabio Estevam <festevam@...il.com>, Jan Petrous <jan.petrous@....nxp.com>, 
 s32@....com, Romain Gantois <romain.gantois@...tlin.com>, 
 Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>, 
 Heiko Stuebner <heiko@...ech.de>, Chen Wang <unicorn_wang@...look.com>, 
 Inochi Amaoto <inochiama@...il.com>, Emil Renner Berthing <kernel@...il.dk>, 
 Minda Chen <minda.chen@...rfivetech.com>, Drew Fustini <fustini@...nel.org>, 
 Guo Ren <guoren@...nel.org>, Fu Wei <wefu@...hat.com>, 
 Nobuhiro Iwamatsu <nobuhiro.iwamatsu.x90@...l.toshiba>, 
 Geert Uytterhoeven <geert+renesas@...der.be>, 
 Magnus Damm <magnus.damm@...il.com>, Maxime Ripard <mripard@...nel.org>, 
 Shuang Liang <liangshuang@...incomputing.com>, 
 Zhi Li <lizhi2@...incomputing.com>, 
 Shangjuan Wei <weishangjuan@...incomputing.com>, 
 "G. Jaya Kumaran" <vineetha.g.jaya.kumaran@...el.com>, 
 Clark Wang <xiaoning.wang@....com>, Linux Team <linux-imx@....com>, 
 Frank Li <Frank.Li@....com>, David Wu <david.wu@...k-chips.com>, 
 Samin Guo <samin.guo@...rfivetech.com>, 
 Christophe Roullier <christophe.roullier@...s.st.com>, 
 Swathi K S <swathi.ks@...sung.com>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
 linux-kernel@...r.kernel.org, netdev@...r.kernel.org, 
 linux-stm32@...md-mailman.stormreply.com, 
 linux-arm-kernel@...ts.infradead.org, 
 Drew Fustini <dfustini@...storrent.com>, linux-sunxi@...ts.linux.dev, 
 linux-amlogic@...ts.infradead.org, linux-mips@...r.kernel.org, 
 imx@...ts.linux.dev, linux-renesas-soc@...r.kernel.org, 
 linux-rockchip@...ts.infradead.org, sophgo@...ts.linux.dev, 
 linux-riscv@...ts.infradead.org, 
 Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: [PATCH v4 3/8] net: stmmac: qcom-ethqos: improve typing in devres
 callback

From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>

It's bad practice to just directly pass void pointers to functions which
expect concrete types. Make it more clear what type ethqos_clks_config()
expects.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
---
 drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
index 8578a2df8cf0d1d8808bcf7e7b57c93eb14c87db..8493131ca32f5c6ca7e1654da0bbf4ffa1eefa4e 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
@@ -726,7 +726,9 @@ static int ethqos_clks_config(void *priv, bool enabled)

 static void ethqos_clks_disable(void *data)
 {
-	ethqos_clks_config(data, false);
+	struct qcom_ethqos *ethqos = data;
+
+	ethqos_clks_config(ethqos, false);
 }

 static void ethqos_ptp_clk_freq_config(struct stmmac_priv *priv)

-- 
2.51.0