linux-kernel - Re: [PATCH RFC] reset: fix BIT macro reference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aQteoBKKmqQ_zWBg@troy-wujie14pro-arch>
Date: Wed, 5 Nov 2025 22:28:43 +0800
From: Troy Mitchell <troy.mitchell@...ux.dev>
To: Encrow Thorne <jyc0019@...il.com>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Troy Mitchell <troy.mitchell@...ux.dev>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC] reset: fix BIT macro reference

On Wed, Nov 05, 2025 at 09:35:02PM +0800, Encrow Thorne wrote:
> RESET_CONTROL_FLAGS_BIT_* macros use BIT(), but reset.h does not
> include bits.h or bitops.h. 
I believe bits.h is enough.
>
> This causes compilation errors when
> including reset.h standalone.
> 
> Include bits.h to make reset.h self-contained.
> 
Please remove below commit message when you send real patch.
And I think you can send real patch now.
> This patch is sent as RFC to discuss whether including bits.h in
> reset.h is appropriate.
> 
> Signed-off-by: Encrow Thorne <jyc0019@...il.com>
> ---
>  include/linux/reset.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/reset.h b/include/linux/reset.h
> index 840d75d172f6..d3102eef085e 100644
> --- a/include/linux/reset.h
> +++ b/include/linux/reset.h
> @@ -5,6 +5,7 @@
>  #include <linux/err.h>
>  #include <linux/errno.h>
>  #include <linux/types.h>
> +#include <linux/bits.h>
with keep sort as what Philipp said:
Reviewed-by: Troy Mitchell <troy.mitchell@...ux.dev>
>  
>  struct device;
>  struct device_node;
> 
> ---
> base-commit: 8fec172c82c2b5f6f8e47ab837c1dc91ee3d1b87
> change-id: 20251105-rfc-reset-include-bits-4ec72344d1a3
> 
> Best regards,
> -- 
> Encrow Thorne <jyc0019@...il.com>
>