linux-kernel - Re: [PATCH v4 2/2] gpio: add gpio-line-mux driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f589ef1b-4347-4771-802f-992dd0928bc3@gmail.com>
Date: Wed, 5 Nov 2025 15:37:24 +0100
From: Jonas Jelonek <jelonek.jonas@...il.com>
To: Peter Rosin <peda@...ntia.se>, Bartosz Golaszewski <brgl@...ev.pl>
Cc: Linus Walleij <linus.walleij@...aro.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Geert Uytterhoeven <geert+renesas@...der.be>,
 linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Thomas Richard <thomas.richard@...tlin.com>
Subject: Re: [PATCH v4 2/2] gpio: add gpio-line-mux driver

Hi,

On 05.11.25 15:19, Peter Rosin wrote:
> Hi!
>
> 2025-11-05 at 14:24, Bartosz Golaszewski wrote:
>> Yes, "muxed-gpio" is good. I can change it myself when applying.
>>
>> Bartosz
> Isn't that the name in the device tree?
>
> Is
>
> 	muxed-gpio-gpios = <&gpio0 2 GPIO_ACTIVE_HIGH>;

This would be quite odd and not what I had in mind when I suggested this.
But I probably didn't express myself good enough.

> really satisfactory? Can you really make that change as you apply
> w/o a re-review of the binding?
>
> Or, are we talking about
>
> 	glm->shared_gpio = devm_gpiod_get(dev, "muxed", GPIOD_ASIS);
>
> and
>
> 	muxed-gpios = <&gpio0 2 GPIO_ACTIVE_HIGH>;
>
> ?

I'd be fine with this, but as you mentioned, it needs a re-review of the bindings.
If it's just about the label being used upon GPIO request, I might switch to
devm_fwnode_gpiod_get_index to explicitly set a different label and keep
"shared" in the bindings and device tree property?

>
> Cheers,
> Peter

Best,
Jonas