[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9baa4aa8c3e5b15cc23b6915ae1466fdeba75291.camel@pengutronix.de>
Date: Wed, 05 Nov 2025 16:16:09 +0100
From: Philipp Zabel <p.zabel@...gutronix.de>
To: Laurentiu Mihalcea <laurentiumihalcea111@...il.com>, Abel Vesa
<abelvesa@...nel.org>, Michael Turquette <mturquette@...libre.com>, Stephen
Boyd <sboyd@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor
Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>, Fabio
Estevam <festevam@...il.com>, Daniel Baluta <daniel.baluta@....com>,
Shengjiu Wang <shengjiu.wang@....com>, Frank Li <Frank.Li@....com>
Cc: linux-clk@...r.kernel.org, imx@...ts.linux.dev,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, Pengutronix Kernel Team
<kernel@...gutronix.de>
Subject: Re: [PATCH v4 1/8] reset: imx8mp-audiomix: Fix bad mask values
On Di, 2025-11-04 at 04:02 -0800, Laurentiu Mihalcea wrote:
> From: Laurentiu Mihalcea <laurentiu.mihalcea@....com>
>
> As per the i.MX8MP TRM, section 14.2 "AUDIO_BLK_CTRL", table 14.2.3.1.1
> "memory map", the definition of the EARC control register shows that the
> EARC controller software reset is controlled via bit 0, while the EARC PHY
> software reset is controlled via bit 1.
>
> This means that the current definitions of IMX8MP_AUDIOMIX_EARC_RESET_MASK
> and IMX8MP_AUDIOMIX_EARC_PHY_RESET_MASK are wrong since their values would
> imply that the EARC controller software reset is controlled via bit 1 and
> the EARC PHY software reset is controlled via bit 2. Fix them.
>
> Fixes: a83bc87cd30a ("reset: imx8mp-audiomix: Prepare the code for more reset bits")
> Cc: stable@...r.kernel.org
> Reviewed-by: Shengjiu Wang <shengjiu.wang@...il.com>
> Reviewed-by: Frank Li <Frank.Li@....com>
> Reviewed-by: Daniel Baluta <daniel.baluta@....com>
> Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@....com>
Applied patch 1 to reset/fixes, thanks!
[1/8] reset: imx8mp-audiomix: Fix bad mask values
https://git.pengutronix.de/cgit/pza/linux/commit/?id=997c06330fd5
regards
Philipp
Powered by blists - more mailing lists