linux-kernel - Re: [PATCH v3 1/3] iio: mpl3115: use get_unaligned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aQtrVNktJcNrFOdx@smile.fi.intel.com>
Date: Wed, 5 Nov 2025 17:20:52 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Antoni Pokusinski <apokusinski01@...il.com>
Cc: jic23@...nel.org, dlechner@...libre.com, nuno.sa@...log.com,
	andy@...nel.org, marcelo.schmitt1@...il.com,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/3] iio: mpl3115: use get_unaligned_be24 to retrieve
 pressure data

On Wed, Nov 05, 2025 at 10:56:13AM +0100, Antoni Pokusinski wrote:
> The pressure measurement result is arranged as 20-bit unsigned value
> residing in three 8-bit registers. Hence, it can be retrieved using
> get_unaligned_be24 and by applying 4-bit shift.

get_unaligned_be24()

Reviewed-by: Andy Shevchenko <andriy.shevchenko@...el.com>
independently on the below.

...

> +		u8 tmp[3];

While at it, you also may rename it to something better

${foo}_be24;

where ${foo} should be replaced to the meaningful name.

-- 
With Best Regards,
Andy Shevchenko