linux-kernel - [PATCH 2/3] drm/rockchip: vop: avoid overflow of clock rate in vop_crtc_atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251105160719.2917175-3-k.yankevich@omp.ru>
Date: Wed, 5 Nov 2025 19:07:18 +0300
From: Karina Yankevich <k.yankevich@....ru>
To: Sandy Huang <hjc@...k-chips.com>
CC: Karina Yankevich <k.yankevich@....ru>, Heiko Stübner
	<heiko@...ech.de>, Andy Yan <andy.yan@...k-chips.com>, Maarten Lankhorst
	<maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-rockchip@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, <lvc-project@...uxtesting.org>, Sergey
 Shtylyov <s.shtylyov@....ru>
Subject: [PATCH 2/3] drm/rockchip: vop: avoid overflow of clock rate in vop_crtc_atomic_enable()

Conversion of clock frequency from kHz to Hz in vop_crtc_atomic_enable()
can lead to integer overflow, since type of drm_display_mode::clock 
is 'int'. Fix it by using 1000UL multiplier to avoid overflow 
at least on 64-bit arches.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 2048e3286f34 ("drm: rockchip: Add basic drm driver")
Signed-off-by: Karina Yankevich <k.yankevich@....ru>
Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>
---
 drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
index b1e2ca84c26d..9a6395db455d 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
@@ -1473,7 +1473,7 @@ static void vop_crtc_atomic_enable(struct drm_crtc *crtc,
 
 	VOP_REG_SET(vop, intr, line_flag_num[0], vact_end);
 
-	clk_set_rate(vop->dclk, adjusted_mode->clock * 1000);
+	clk_set_rate(vop->dclk, adjusted_mode->clock * 1000UL);
 
 	VOP_REG_SET(vop, common, standby, 0);
 	mutex_unlock(&vop->vop_lock);
-- 
2.34.1