linux-kernel - Re: [PATCH v4 2/2] gpio: add gpio-line-mux driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ebeada4e-d739-4a8f-8e5f-a8de0d4e885e@gmail.com>
Date: Wed, 5 Nov 2025 16:49:31 +0100
From: Jonas Jelonek <jelonek.jonas@...il.com>
To: Bartosz Golaszewski <brgl@...ev.pl>, Peter Rosin <peda@...ntia.se>
Cc: Linus Walleij <linus.walleij@...aro.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Geert Uytterhoeven <geert+renesas@...der.be>,
 linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Thomas Richard <thomas.richard@...tlin.com>
Subject: Re: [PATCH v4 2/2] gpio: add gpio-line-mux driver

Hi,

On 05.11.25 16:37, Bartosz Golaszewski wrote:
> Ah, that's what you get for revieweing with a fever. :/
>
> You're right of course.
>
> And yes, we'd need to modify the bindings.
>
>> Or, are we talking about
>>
>>         glm->shared_gpio = devm_gpiod_get(dev, "muxed", GPIOD_ASIS);
>>
>> and
>>
>>         muxed-gpios = <&gpio0 2 GPIO_ACTIVE_HIGH>;
>>
>> ?
>>
> I would make it: glm->muxed_gpio = devm_gpiod_get(dev, "muxed", GPIOD_ASIS);
>
> Jonas, could you please send another version with that addressed both
> here and in the bindings?

Yes, I'll do.

> Bartosz

Best,
Jonas