linux-kernel - Re: [PATCH] crypto: rockchip - drop redundant crypto_skcipher

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <70685d39-9fc4-4e1d-a6a6-bd82cac9b007@web.de>
Date: Wed, 5 Nov 2025 17:55:56 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Karina Yankevich <k.yankevich@....ru>, linux-crypto@...r.kernel.org,
 linux-rockchip@...ts.infradead.org, lvc-project@...uxtesting.org,
 Corentin Labbe <clabbe@...libre.com>, Sergey Shtylyov <s.shtylyov@....ru>
Cc: LKML <linux-kernel@...r.kernel.org>, "David S. Miller"
 <davem@...emloft.net>, Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [PATCH] crypto: rockchip - drop redundant
 crypto_skcipher_ivsize() calls

> The function already initialized the ivsize variable 
> at the point of declaration, let's use it instead of 
> calling crypto_skcipher_ivsize() extra couple times.
…

* You may occasionally put more than 52 characters into text lines
  of such a change description.
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.18-rc4#n658

* How do you think about to reduce the scope for such a local variable?

Regards,
Markus