linux-kernel - Re: [PATCH v2] reset: fix BIT macro reference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251105170006.GA487100@hailin-HP-Pavilion-Laptop-14-dv0xxx>
Date: Thu, 6 Nov 2025 01:00:06 +0800
From: Encrow Thorne <jyc0019@...il.com>
To: Philipp Zabel <p.zabel@...gutronix.de>
Cc: Troy Mitchell <troy.mitchell@...ux.dev>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] reset: fix BIT macro reference

On Wed, Nov 05, 2025 at 04:51:33PM +0100, Philipp Zabel wrote:
> On Mi, 2025-11-05 at 23:40 +0800, Encrow Thorne wrote:
> > RESET_CONTROL_FLAGS_BIT_* macros use BIT(), but reset.h does not
> > include bits.h or bitops.h. This causes compilation errors when
>                  ^^^^^^^^^^^
> Troy suggested "or bitops.h" can be dropped.
> 
> > including reset.h standalone.
> > 
> > Include bits.h to make reset.h self-contained.
> > 
> > Suggested-by: Troy Mitchell <troy.mitchell@...ux.dev>
> > Reviewed-by: Troy Mitchell <troy.mitchell@...ux.dev>
> > Signed-off-by: Encrow Thorne <jyc0019@...il.com>
> > ---
> > Changes in v2:
> > - EDITME: describe what is new in this series revision.
> > - EDITME: use bulletpoints and terse descriptions.
> 
> These should be replaced with a short description of the changes
> relative to v1.
> 
> 
Sorry for the oversight on my side regarding the “Changes in v2” placeholders.
Do you recommend I resend a corrected v2 now, or wait and include it in a v3?
Thanks for your guidance.

				-Encrow
> Otherwise,
> 
> Reviewed-by: Philipp Zabel <p.zabel@...gutronix.de>
> 
> regards
> Philipp