linux-kernel - [PATCH v2] PCI: of: Downgrade error message on missing of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <955bc7a9b78678fad4b705c428e8b45aeb0cbf3c.1762367117.git.andrea.porta@suse.com>
Date: Wed,  5 Nov 2025 19:33:40 +0100
From: Andrea della Porta <andrea.porta@...e.com>
To: Bjorn Helgaas <bhelgaas@...gle.com>,
	linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	mbrugger@...e.com,
	guillaume.gardet@....com,
	tiwai@...e.com
Cc: Andrea della Porta <andrea.porta@...e.com>
Subject: [PATCH v2] PCI: of: Downgrade error message on missing of_root node

When CONFIG_PCI_DYNAMIC_OF_NODES is enabled, an error message
is generated if no 'of_root' node is defined.

On DT-based systems, this cannot happen as a root DT node is
always present. On ACPI-based systems, this is not a true error
because a DT is not used.

Downgrade the pr_err() to pr_info() and reword the message text
to be less context specific.

Signed-off-by: Andrea della Porta <andrea.porta@...e.com>
---
CHANGES in V2:

* message text reworded to be less context specific (Bjorn)
---
 drivers/pci/of.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/of.c b/drivers/pci/of.c
index 3579265f1198..872c36b195e3 100644
--- a/drivers/pci/of.c
+++ b/drivers/pci/of.c
@@ -775,7 +775,7 @@ void of_pci_make_host_bridge_node(struct pci_host_bridge *bridge)
 
 	/* Check if there is a DT root node to attach the created node */
 	if (!of_root) {
-		pr_err("of_root node is NULL, cannot create PCI host bridge node\n");
+		pr_info("Missing DeviceTree, cannot create PCI host bridge node\n");
 		return;
 	}
 
-- 
2.35.3