| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20251105184050.000016f0@huawei.com>
Date: Wed, 5 Nov 2025 18:40:50 +0000
From: Jonathan Cameron <jonathan.cameron@...wei.com>
To: Oleksij Rempel <o.rempel@...gutronix.de>
CC: Jonathan Cameron <jic23@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
<kernel@...gutronix.de>, <linux-kernel@...r.kernel.org>,
<linux-iio@...r.kernel.org>, <devicetree@...r.kernel.org>, Andy Shevchenko
<andy.shevchenko@...il.com>, David Lechner <dlechner@...libre.com>, Nuno
Sá <nuno.sa@...log.com>
Subject: Re: [PATCH v1 1/2] bindings: iio: adc: Add bindings for TI
ADS131M0x ADCs
On Wed, 5 Nov 2025 15:38:13 +0100
Oleksij Rempel <o.rempel@...gutronix.de> wrote:
> Add device tree bindings documentation for the Texas Instruments
> ADS131M0x analog-to-digital converters. This family includes the ADS131M02,
> ADS131M03, ADS131M04, ADS131M06, and ADS131M08 variants.
Hi Olkesij,
Add a clear statement of difference between them that means we can't
use a single fallback compatible. You kind of state it in the binding
(number of channels) but having it here explicitly makes for easier review.
>
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> ---
> .../bindings/iio/adc/ti,ads131m08.yaml | 162 ++++++++++++++++++
> 1 file changed, 162 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ads131m08.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads131m08.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads131m08.yaml
> new file mode 100644
> index 000000000000..193ac84c41cd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads131m08.yaml
> @@ -0,0 +1,162 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/ti,ads131m08.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments ADS131M0x 2-, 3-, 4-, 6- and 8-Channel ADCs
> +
> +maintainers:
> + - Oleksij Rempel <o.rempel@...gutronix.de>
> +
> +description: |
> + The ADS131M0x are a family of multichannel, simultaneous sampling,
> + 24-bit, delta-sigma, analog-to-digital converters (ADCs) with a
> + built-in programmable gain amplifier (PGA) and internal reference.
> + Communication with the ADC chip is via SPI.
> +
> + Datasheets:
> + - ADS131M08: https://www.ti.com/lit/ds/symlink/ads131m08.pdf
> + - ADS131M06: https://www.ti.com/lit/ds/symlink/ads131m06.pdf
> + - ADS131M04: https://www.ti.com/lit/ds/symlink/ads131m04.pdf
> + - ADS131M03: https://www.ti.com/lit/ds/symlink/ads131m03.pdf
> + - ADS131M02: https://www.ti.com/lit/ds/symlink/ads131m02.pdf
Trivial but seems a little odd to have these in reverse order of the compatibles.
> +
> +properties:
> + compatible:
> + enum:
> + - ti,ads131m02
> + - ti,ads131m03
> + - ti,ads131m04
> + - ti,ads131m06
> + - ti,ads131m08
> +
> + reg:
> + description: SPI chip select number.
> +
> + clocks:
> + description:
> + Phandle to the external clock source required by the ADC's CLKIN pin.
> + The datasheet recommends specific frequencies based on the desired power
> + mode (e.g., 8.192 MHz for High-Resolution mode).
> + maxItems: 1
> +
> + '#address-cells':
> + const: 1
> +
> + '#size-cells':
> + const: 0
There should be some supplies here.
Looks like REFIN is optional but AVDD and DVDD are required.
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> +
> +patternProperties:
> + "^channel@([0-7])$":
> + type: object
> + $ref: /schemas/iio/adc/adc.yaml#
> + description: |
No need for | on this one as I don't think formatting needs to be controlled.
> + Properties for a single ADC channel. The maximum valid channel number
> + depends on the specific compatible string used (e.g., 0-1 for ads131m02,
> + 0-7 for ads131m08).
> +
> + properties:
> + reg:
> + description: The channel index (0-7).
> + minimum: 0
> + maximum: 7 # Max channels on ADS131M08
> +
> + label: true
> +
> + required:
> + - reg
> +
> + unevaluatedProperties: false
> +
> +allOf:
> + - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: ti,ads131m02
> + then:
> + patternProperties:
> + "^channel@[0-7]$":
> + properties:
> + reg:
> + maximum: 1
> + "^channel@([2-7])$": false
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: ti,ads131m03
> + then:
> + patternProperties:
> + "^channel@[0-7]$":
> + properties:
> + reg:
> + maximum: 2
> + "^channel@([3-7])$": false
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: ti,ads131m04
> + then:
> + patternProperties:
> + "^channel@[0-7]$":
> + properties:
> + reg:
> + maximum: 3
> + "^channel@([4-7])$": false
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: ti,ads131m06
> + then:
> + patternProperties:
> + "^channel@[0-7]$":
> + properties:
> + reg:
> + maximum: 5
> + "^channel@([6-7])$": false
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/stm32mp1-clks.h>
> +
> + spi1 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + adc@0 {
> + compatible = "ti,ads131m02";
> + reg = <0>;
> + spi-max-frequency = <8000000>;
> +
> + clocks = <&rcc CK_MCO2>;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + channel@0 {
> + reg = <0>;
> + label = "input_voltage";
> + };
> +
> + channel@1 {
> + reg = <1>;
> + label = "input_current";
> + };
> + };
> + };
Powered by blists - more mailing lists