linux-kernel - Re: [PATCH net-next v2 4/5] net/mlx5e: Add PSP stats support for Rx/Tx flows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5d816624-dbfb-4851-a834-94d52677863d@gmail.com>
Date: Wed, 5 Nov 2025 15:31:50 -0500
From: Daniel Zahka <daniel.zahka@...il.com>
To: Cosmin Ratiu <cratiu@...dia.com>,
 "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
 Saeed Mahameed <saeedm@...dia.com>, "davem@...emloft.net"
 <davem@...emloft.net>, Tariq Toukan <tariqt@...dia.com>,
 "leon@...nel.org" <leon@...nel.org>, "shuah@...nel.org" <shuah@...nel.org>,
 Mark Bloch <mbloch@...dia.com>, "kuba@...nel.org" <kuba@...nel.org>,
 "horms@...nel.org" <horms@...nel.org>,
 "donald.hunter@...il.com" <donald.hunter@...il.com>,
 Boris Pismenny <borisp@...dia.com>, "edumazet@...gle.com"
 <edumazet@...gle.com>, "pabeni@...hat.com" <pabeni@...hat.com>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>
Subject: Re: [PATCH net-next v2 4/5] net/mlx5e: Add PSP stats support for
 Rx/Tx flows



On 10/30/25 12:11 PM, Cosmin Ratiu wrote:
>> +static void
>> +mlx5e_psp_get_stats(struct psp_dev *psd, struct psp_dev_stats
>> *stats)
>> +{
>> +	struct mlx5e_priv *priv = netdev_priv(psd->main_netdev);
>> +	struct mlx5e_psp_stats nstats;
>> +
>> +	mlx5e_accel_psp_fs_get_stats_fill(priv, &nstats);
> I don't see the point of the intermediate struct mlx5e_psp_stats, this
> function could query counters directly into stats.

Just because mlx5_fc_query() populates packet and byte counts, but 
psp_dev_stats required stats only have byte counts for two of the 
categories.

I'll address the rest of you comments on the respin. Thanks for taking a 
look.