linux-kernel - Re: [PATCH net v1 2/2] gve: use max allowed ring size for ZC page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHS8izP3phG1FzAztGM-6P4gXopBGdNEXGODuvPasU+DH+7reQ@mail.gmail.com>
Date: Wed, 5 Nov 2025 14:44:37 -0800
From: Mina Almasry <almasrymina@...gle.com>
To: Jesper Dangaard Brouer <hawk@...nel.org>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Joshua Washington <joshwash@...gle.com>, Harshitha Ramamurthy <hramamurthy@...gle.com>, 
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Ilias Apalodimas <ilias.apalodimas@...aro.org>, Simon Horman <horms@...nel.org>, 
	Willem de Bruijn <willemb@...gle.com>, ziweixiao@...gle.com, 
	Vedant Mathur <vedantmathur@...gle.com>
Subject: Re: [PATCH net v1 2/2] gve: use max allowed ring size for ZC page_pools

On Wed, Nov 5, 2025 at 1:58 PM Jesper Dangaard Brouer <hawk@...nel.org> wrote:
>
>
>
> On 05/11/2025 21.07, Mina Almasry wrote:
> > diff --git a/drivers/net/ethernet/google/gve/gve_buffer_mgmt_dqo.c b/drivers/net/ethernet/google/gve/gve_buffer_mgmt_dqo.c
> > index 0e2b703c673a..f63ffdd3b3ba 100644
> > --- a/drivers/net/ethernet/google/gve/gve_buffer_mgmt_dqo.c
> > +++ b/drivers/net/ethernet/google/gve/gve_buffer_mgmt_dqo.c
> > @@ -8,6 +8,8 @@
> >   #include "gve.h"
> >   #include "gve_utils.h"
> >
> > +#include "net/netdev_queues.h"
> > +
>
> Shouldn't this be with "<net/netdev_queues.h>" ?
>

Yes, will do.

> And why include this and not net/page_pool/types.h that you just
> modified in previous patch?
>

netdev_queues.h is actually for netif_rxq_has_unreadable_mp. I did
indeed forget to explicitly include net/page_pool/types.h for the
PAGE_POOL_MAX_RING_SIZE. Will also do in v2.

-- 
Thanks,
Mina