linux-kernel - Re: [PATCH net v1 1/2] page_pool: expose max page pool ring size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHS8izM+sPsaB7iVbNu7DEu9qH-89c_XDdMM=SpWFT3Ywq6k3g@mail.gmail.com>
Date: Wed, 5 Nov 2025 14:56:39 -0800
From: Mina Almasry <almasrymina@...gle.com>
To: Jesper Dangaard Brouer <hawk@...nel.org>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Joshua Washington <joshwash@...gle.com>, Harshitha Ramamurthy <hramamurthy@...gle.com>, 
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Ilias Apalodimas <ilias.apalodimas@...aro.org>, Simon Horman <horms@...nel.org>, 
	Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net v1 1/2] page_pool: expose max page pool ring size

On Wed, Nov 5, 2025 at 1:56 PM Jesper Dangaard Brouer <hawk@...nel.org> wrote:
> > diff --git a/include/net/page_pool/types.h b/include/net/page_pool/types.h
> > index 1509a536cb85..5edba3122b10 100644
> > --- a/include/net/page_pool/types.h
> > +++ b/include/net/page_pool/types.h
> > @@ -58,6 +58,8 @@ struct pp_alloc_cache {
> >       netmem_ref cache[PP_ALLOC_CACHE_SIZE];
> >   };
> >
> > +#define PAGE_POOL_MAX_RING_SIZE 16384
> > +
>
> IIRC this was recently reduced to 16384 (from 32K), do you have a
> use-case for higher limits?
>

Yes, I noticed that. Increasing to 16384 resolved my issue, so I did
not feel the need to revert back to 32K.

We're expanding testing more and more and I may run into another issue
that asks that I re-increase the limit (maybe with a check that it's
indeed a ZC configuration, so no extra memory will be pinned), but for
now I did not find a justification for that.

-- 
Thanks,
Mina